'Re: Review Request 119012: vi-mode: refactor vimarks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119012: vi-mode: refactor vimarks
From:       "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date:       2014-06-29 16:47:03
Message-ID: 20140629164703.7884.30526 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119012/
-----------------------------------------------------------

(Updated June 29, 2014, 4:47 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Miquel SabatĂŠ SolĂ .

Repository: ktexteditor

Description
-------

Larger refactor with the included fix for restoring only the user marks visibility.

The names are probably not ideal, suggestions welcomed. The \
KateViInputModeManager::error and KateViInputModeManager::message would probably need \
more attention too.

Diffs
-----

  src/CMakeLists.txt 71f5ec5 
  src/inputmode/kateviinputmode.cpp 3059a62 
  src/vimode/katevicmds.cpp eeb37d7 
  src/vimode/katevicommandrangeexpressionparser.cpp 79620d4 
  src/vimode/kateviinputmodemanager.h 0d08d2d 
  src/vimode/kateviinputmodemanager.cpp a44b8a4 
  src/vimode/kateviinsertmode.cpp 8b8f96e 
  src/vimode/katevinormalmode.cpp 9643d60 
  src/vimode/katevivisualmode.cpp 25d4bd9 
  src/vimode/marks.h PRE-CREATION 
  src/vimode/marks.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119012/diff/

Testing
-------

make test + manual testing

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119012/">https://git.reviewboard.kde.org/r/119012/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Miquel SabatĂŠ SolĂ .</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated June 29, 2014, 4:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Larger refactor with the included fix for restoring only the user marks \
visibility.

The names are probably not ideal, suggestions welcomed. The \
KateViInputModeManager::error and KateViInputModeManager::message would probably need \
more attention too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">make test + manual testing</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(71f5ec5)</span></li>

 <li>src/inputmode/kateviinputmode.cpp <span style="color: \
grey">(3059a62)</span></li>

 <li>src/vimode/katevicmds.cpp <span style="color: grey">(eeb37d7)</span></li>

 <li>src/vimode/katevicommandrangeexpressionparser.cpp <span style="color: \
grey">(79620d4)</span></li>

 <li>src/vimode/kateviinputmodemanager.h <span style="color: \
grey">(0d08d2d)</span></li>

 <li>src/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(a44b8a4)</span></li>

 <li>src/vimode/kateviinsertmode.cpp <span style="color: grey">(8b8f96e)</span></li>

 <li>src/vimode/katevinormalmode.cpp <span style="color: grey">(9643d60)</span></li>

 <li>src/vimode/katevivisualmode.cpp <span style="color: grey">(25d4bd9)</span></li>

 <li>src/vimode/marks.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/vimode/marks.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119012/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 