--===============2339265151034118815== Content-Type: multipart/alternative; boundary="===============3351982311564104018==" --===============3351982311564104018== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119012/ ----------------------------------------------------------- (Updated June 29, 2014, 4:47 p.m.) Status ------ This change has been marked as submitted. Review request for Kate and Miquel Sabaté Solà. Repository: ktexteditor Description ------- Larger refactor with the included fix for restoring only the user marks visibility. The names are probably not ideal, suggestions welcomed. The KateViInputModeManager::error and KateViInputModeManager::message would probably need more attention too. Diffs ----- src/CMakeLists.txt 71f5ec5 src/inputmode/kateviinputmode.cpp 3059a62 src/vimode/katevicmds.cpp eeb37d7 src/vimode/katevicommandrangeexpressionparser.cpp 79620d4 src/vimode/kateviinputmodemanager.h 0d08d2d src/vimode/kateviinputmodemanager.cpp a44b8a4 src/vimode/kateviinsertmode.cpp 8b8f96e src/vimode/katevinormalmode.cpp 9643d60 src/vimode/katevivisualmode.cpp 25d4bd9 src/vimode/marks.h PRE-CREATION src/vimode/marks.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119012/diff/ Testing ------- make test + manual testing Thanks, Michal Humpula --===============3351982311564104018== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119012/

This change has been marked as submitted.

Review request for Kate and Miquel Sabaté Solà.
By Michal Humpula.

Updated June 29, 2014, 4:47 p.m.

Repository: ktexteditor

Description 

Larger refactor with the included fix for restoring only the user marks visibility.

The names are probably not ideal, suggestions welcomed. The KateViInputModeManager::error and KateViInputModeManager::message would probably need more attention too.

Testing 

make test + manual testing

Diffs

  • src/CMakeLists.txt (71f5ec5)
  • src/inputmode/kateviinputmode.cpp (3059a62)
  • src/vimode/katevicmds.cpp (eeb37d7)
  • src/vimode/katevicommandrangeexpressionparser.cpp (79620d4)
  • src/vimode/kateviinputmodemanager.h (0d08d2d)
  • src/vimode/kateviinputmodemanager.cpp (a44b8a4)
  • src/vimode/kateviinsertmode.cpp (8b8f96e)
  • src/vimode/katevinormalmode.cpp (9643d60)
  • src/vimode/katevivisualmode.cpp (25d4bd9)
  • src/vimode/marks.h (PRE-CREATION)
  • src/vimode/marks.cpp (PRE-CREATION)

View Diff
--===============3351982311564104018==-- --===============2339265151034118815== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============2339265151034118815==--