'Re: Review Request 117064: removing EditorPrivate::enableUnitTestMode in favor of more specific view'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117064: removing EditorPrivate::enableUnitTestMode in favor of more specific view
From:       "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date:       2014-06-28 13:27:11
Message-ID: 20140628132711.18724.7847 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117064/
-----------------------------------------------------------

(Updated June 28, 2014, 1:27 p.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: ktexteditor

Description
-------

According to Dominik, the issue with oxygen style was fixed, so the KateAnimation \
doesn't need that quirk in order to pass on Jenkins. But I'm afraid that on some \
configurations with style hinting "no animation" this might randomly fail. So adding \
specific view config option, to ensure the tested behavior.

Expecting heavy fighting so go ahead and shoot:)

Diffs
-----

  autotests/src/messagetest.cpp 4aee9db 
  src/utils/kateconfig.h 2b69013 
  src/utils/kateconfig.cpp 1cd646f 
  src/utils/kateglobal.h 420845c 
  src/utils/kateglobal.cpp 4b93386 
  src/view/kateanimation.cpp c3a1ca0 

Diff: https://git.reviewboard.kde.org/r/117064/diff/

Testing
-------

make test

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117064/">https://git.reviewboard.kde.org/r/117064/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated June 28, 2014, 1:27 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to Dominik, the issue with oxygen style was fixed, so the \
KateAnimation doesn&#39;t need that quirk in order to pass on Jenkins. But I&#39;m \
afraid that on some configurations with style hinting &quot;no animation&quot; this \
might randomly fail. So adding specific view config option, to ensure the tested \
behavior.

Expecting heavy fighting so go ahead and shoot:)
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">make test</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/messagetest.cpp <span style="color: grey">(4aee9db)</span></li>

 <li>src/utils/kateconfig.h <span style="color: grey">(2b69013)</span></li>

 <li>src/utils/kateconfig.cpp <span style="color: grey">(1cd646f)</span></li>

 <li>src/utils/kateglobal.h <span style="color: grey">(420845c)</span></li>

 <li>src/utils/kateglobal.cpp <span style="color: grey">(4b93386)</span></li>

 <li>src/view/kateanimation.cpp <span style="color: grey">(c3a1ca0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117064/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 