'Re: Review Request 116996: add ability to disable file config read/writes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 116996: add ability to disable file config read/writes
From:       "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date:       2014-06-28 13:26:45
Message-ID: 20140628132645.18724.70976 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116996/
-----------------------------------------------------------

(Updated June 28, 2014, 1:26 p.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: ktexteditor

Description
-------

This is my quick solition to config read/write problem when running tests. This still \
requires setting one env variable, but at least it's more general now. After this all \
the tests can have in their init() call "setenv("KTEXTEDITOR_USECONFIG", "false"); \
and no var will be needed to setup manualy.

Code is suboptimal, and if everyone is ok with solution, I will fixed that.

Diffs
-----

  src/utils/kateglobal.h 420845c 
  src/utils/kateglobal.cpp 4b93386 
  src/vimode/kateviglobal.h 38b4d3e 
  src/vimode/kateviglobal.cpp 55757d9 

Diff: https://git.reviewboard.kde.org/r/116996/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116996/">https://git.reviewboard.kde.org/r/116996/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated June 28, 2014, 1:26 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is my quick solition to config read/write problem when running \
tests. This still requires setting one env variable, but at least it&#39;s more \
general now. After this all the tests can have in their init() call \
&quot;setenv(&quot;KTEXTEDITOR_USECONFIG&quot;, &quot;false&quot;); and no var will \
be needed to setup manualy.

Code is suboptimal, and if everyone is ok with solution, I will fixed that.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/utils/kateglobal.h <span style="color: grey">(420845c)</span></li>

 <li>src/utils/kateglobal.cpp <span style="color: grey">(4b93386)</span></li>

 <li>src/vimode/kateviglobal.h <span style="color: grey">(38b4d3e)</span></li>

 <li>src/vimode/kateviglobal.cpp <span style="color: grey">(55757d9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116996/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 