'Re: Review Request 118616: Add action to reload syntax highlighting files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 118616: Add action to reload syntax highlighting files
From:       "Phil Schaf" <flying-sheep () web ! de>
Date:       2014-06-22 9:31:53
Message-ID: 20140622093153.31295.15576 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118616/#review60687
-----------------------------------------------------------

is there some developer mode for kate? that e.g. adds advanced logging and stuff?

because if that's the case, we could watch the syntax highlighting directories if \
that mode is active, and reload changed files automatically

(i'm against doing that per default, because of the performance implications of \
adding hundreds of file watches, but it would be perfect for a developer mode)

- Phil Schaf

On June 8, 2014, 1:12 p.m., Christoph Rüßler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118616/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 1:12 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> This patch adds an action to the Kate component that allows the reloading of the \
> syntax highlighting files. 
> Since I am not very familiar with the codebase I might have overlooked something, \
> especially related to memory management. 
> Please let me know if I can improve the patch!
> 
> 
> Diffs
> -----
> 
> part/syntax/katehighlight.h c2d4397e45d0dcba8fa5e822710cae8ea1643aee 
> part/syntax/katehighlight.cpp 7d956e53b0aee2a7fb5a636de18858a736c65ae4 
> part/view/kateview.h 6a522dabe4b1c9c96a8157abfb8716faba049234 
> part/view/kateview.cpp 5ede57e9af184c1f16098dadccec34211497d15a 
> 
> Diff: https://git.reviewboard.kde.org/r/118616/diff/
> 
> 
> Testing
> -------
> 
> I tested that the reloading works by editing the Markdown syntax highlighting file. \
> After applying a change and reloading the file using the previously set shortcut, \
> the highlighting changed correctly. 
> 
> Thanks,
> 
> Christoph Rüßler
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118616/">https://git.reviewboard.kde.org/r/118616/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is there some developer \
mode for kate? that e.g. adds advanced logging and stuff?

because if that's the case, we could watch the syntax highlighting directories if \
that mode is active, and reload changed files automatically

(i'm against doing that per default, because of the performance implications of \
adding hundreds of file watches, but it would be perfect for a developer mode)</pre>  \
<br />

<p>- Phil Schaf</p>

<br />
<p>On June 8th, 2014, 1:12 p.m. UTC, Christoph Rüßler wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Christoph Rüßler.</div>

<p style="color: grey;"><i>Updated June 8, 2014, 1:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds an action to the Kate component that allows the \
reloading of the syntax highlighting files.

Since I am not very familiar with the codebase I might have overlooked something, \
especially related to memory management.

Please let me know if I can improve the patch!</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested that the reloading works by editing the Markdown syntax \
highlighting file. After applying a change and reloading the file using the \
previously set shortcut, the highlighting changed correctly.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/katehighlight.h <span style="color: \
grey">(c2d4397e45d0dcba8fa5e822710cae8ea1643aee)</span></li>

 <li>part/syntax/katehighlight.cpp <span style="color: \
grey">(7d956e53b0aee2a7fb5a636de18858a736c65ae4)</span></li>

 <li>part/view/kateview.h <span style="color: \
grey">(6a522dabe4b1c9c96a8157abfb8716faba049234)</span></li>

 <li>part/view/kateview.cpp <span style="color: \
grey">(5ede57e9af184c1f16098dadccec34211497d15a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118616/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 