From kwrite-devel Sun Jun 22 09:31:53 2014 From: "Phil Schaf" Date: Sun, 22 Jun 2014 09:31:53 +0000 To: kwrite-devel Subject: Re: Review Request 118616: Add action to reload syntax highlighting files Message-Id: <20140622093153.31295.15576 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=140342952913568 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8023322221507023534==" --===============8023322221507023534== Content-Type: multipart/alternative; boundary="===============8807654678292997893==" --===============8807654678292997893== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118616/#review60687 ----------------------------------------------------------- is there some developer mode for kate? that e.g. adds advanced logging and stuff? because if that’s the case, we could watch the syntax highlighting directories if that mode is active, and reload changed files automatically (i’m against doing that per default, because of the performance implications of adding hundreds of file watches, but it would be perfect for a developer mode) - Phil Schaf On June 8, 2014, 1:12 p.m., Christoph Rüßler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118616/ > ----------------------------------------------------------- > > (Updated June 8, 2014, 1:12 p.m.) > > > Review request for Kate. > > > Repository: kate > > > Description > ------- > > This patch adds an action to the Kate component that allows the reloading of the syntax highlighting files. > > Since I am not very familiar with the codebase I might have overlooked something, especially related to memory management. > > Please let me know if I can improve the patch! > > > Diffs > ----- > > part/syntax/katehighlight.h c2d4397e45d0dcba8fa5e822710cae8ea1643aee > part/syntax/katehighlight.cpp 7d956e53b0aee2a7fb5a636de18858a736c65ae4 > part/view/kateview.h 6a522dabe4b1c9c96a8157abfb8716faba049234 > part/view/kateview.cpp 5ede57e9af184c1f16098dadccec34211497d15a > > Diff: https://git.reviewboard.kde.org/r/118616/diff/ > > > Testing > ------- > > I tested that the reloading works by editing the Markdown syntax highlighting file. After applying a change and reloading the file using the previously set shortcut, the highlighting changed correctly. > > > Thanks, > > Christoph Rüßler > > --===============8807654678292997893== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118616/ 

is there some developer mode for kate? that e.g. adds advanced logging and stuff?

because if that’s the case, we could watch the syntax highlighting directories if that mode is active, and reload changed files automatically

(i’m against doing that per default, because of the performance implications of adding hundreds of file watches, but it would be perfect for a developer mode)

- Phil Schaf


On June 8th, 2014, 1:12 p.m. UTC, Christoph Rüßler wrote:

Review request for Kate.
By Christoph Rüßler.

Updated June 8, 2014, 1:12 p.m.

Repository: kate

Description 

This patch adds an action to the Kate component that allows the reloading of the syntax highlighting files.

Since I am not very familiar with the codebase I might have overlooked something, especially related to memory management.

Please let me know if I can improve the patch!

Testing 

I tested that the reloading works by editing the Markdown syntax highlighting file. After applying a change and reloading the file using the previously set shortcut, the highlighting changed correctly.

Diffs

  • part/syntax/katehighlight.h (c2d4397e45d0dcba8fa5e822710cae8ea1643aee)
  • part/syntax/katehighlight.cpp (7d956e53b0aee2a7fb5a636de18858a736c65ae4)
  • part/view/kateview.h (6a522dabe4b1c9c96a8157abfb8716faba049234)
  • part/view/kateview.cpp (5ede57e9af184c1f16098dadccec34211497d15a)

View Diff
--===============8807654678292997893==-- --===============8023322221507023534== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============8023322221507023534==--