[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117776: indenter for the ada language.
From: "trevor blight" <trevor-b () ovi ! com>
Date: 2014-04-26 22:52:52
Message-ID: 20140426225252.23578.51150 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 26, 2014, 12:51 p.m., Christoph Cullmann wrote:
> > If the vim indentation maintainer has no problems with that, I am fine, too.
> > Nice addition, but it should be ported to ktexteditor master, too, please.
now pushed to kate master. will push to ktexteditor in the next few days
- trevor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117776/#review56613
-----------------------------------------------------------
On April 25, 2014, 7:16 p.m., trevor blight wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117776/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 7:16 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> here is an indenter for the ada language.
> As per comments in the script, this indenter is derived from the vim ada indenter. \
> It has been extended to better accommodate multi-line statements, nested \
> parenthesis, recognises extra keywords, etc.
> Note that vim uses it own uganda licence, but as I read it, vim code can be \
> modified and released as GPL2. I have also contacted the vim ada indenter \
> maintainer who has no problem with this code going into the kate code base.
> This patch contains the ada.js indenter file, an updated ada.xml and test programs.
>
>
> Diffs
> -----
>
> part/script/data/indentation/ada.js PRE-CREATION
> part/syntax/data/ada.xml 9bc6b76
> tests/data/indent/ada/.kateconfig PRE-CREATION
> tests/data/indent/ada/closepar2/expected PRE-CREATION
> tests/data/indent/ada/closepar2/input.js PRE-CREATION
> tests/data/indent/ada/closepar2/origin PRE-CREATION
> tests/data/indent/ada/longtest/expected PRE-CREATION
> tests/data/indent/ada/longtest/input.js PRE-CREATION
> tests/data/indent/ada/longtest/origin PRE-CREATION
> tests/data/indent/ada/newline/expected PRE-CREATION
> tests/data/indent/ada/newline/input.js PRE-CREATION
> tests/data/indent/ada/newline/origin PRE-CREATION
> tests/data/indent/ada/openpar2/expected PRE-CREATION
> tests/data/indent/ada/openpar2/input.js PRE-CREATION
> tests/data/indent/ada/openpar2/origin PRE-CREATION
> tests/data/indent/ada/prep1/expected PRE-CREATION
> tests/data/indent/ada/prep1/input.js PRE-CREATION
> tests/data/indent/ada/prep1/origin PRE-CREATION
> tests/data/indent/ada/trig1/expected PRE-CREATION
> tests/data/indent/ada/trig1/input.js PRE-CREATION
> tests/data/indent/ada/trig1/origin PRE-CREATION
> tests/indenttest.h 145421a
> tests/indenttest.cpp 5b23873
>
> Diff: https://git.reviewboard.kde.org/r/117776/diff/
>
>
> Testing
> -------
>
> yes, using the attached tests. all pass, takes about 4 secs on my system.
>
>
> Thanks,
>
> trevor blight
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117776/">https://git.reviewboard.kde.org/r/117776/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 26th, 2014, 12:51 p.m. UTC, <b>Christoph \
Cullmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If the vim indentation maintainer has no problems with that, I am fine, \
too. Nice addition, but it should be ported to ktexteditor master, too, please.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">now pushed to kate \
master. will push to ktexteditor in the next few days </pre> <br />
<p>- trevor</p>
<br />
<p>On April 25th, 2014, 7:16 p.m. UTC, trevor blight wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By trevor blight.</div>
<p style="color: grey;"><i>Updated April 25, 2014, 7:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">here is an indenter for the ada language. As per comments in the script, \
this indenter is derived from the vim ada indenter. It has been extended to better \
accommodate multi-line statements, nested parenthesis, recognises extra keywords, \
etc.
Note that vim uses it own uganda licence, but as I read it, vim code can be modified \
and released as GPL2. I have also contacted the vim ada indenter maintainer who has \
no problem with this code going into the kate code base.
This patch contains the ada.js indenter file, an updated ada.xml and test programs.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, using the attached tests. all pass, takes about 4 secs on my \
system.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/script/data/indentation/ada.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/syntax/data/ada.xml <span style="color: grey">(9bc6b76)</span></li>
<li>tests/data/indent/ada/.kateconfig <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/closepar2/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/closepar2/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/closepar2/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/longtest/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/longtest/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/longtest/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/newline/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/newline/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/newline/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/openpar2/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/openpar2/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/openpar2/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/prep1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/prep1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/prep1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/trig1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/trig1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/ada/trig1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/indenttest.h <span style="color: grey">(145421a)</span></li>
<li>tests/indenttest.cpp <span style="color: grey">(5b23873)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117776/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic