[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117338: Use a model and a TreeView for build commands
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2014-04-21 19:49:17
Message-ID: 20140421194917.25091.84134 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 17, 2014, 8:18 p.m., Alexander Neundorf wrote:
> > I don't like that the "build default target" action has been removed. Being able \
> > to just build the whole thing is good. I don't mind removing the special support \
> > for the "clean" target.
> > Whether treeview or combobox+list... I don't have a strong opinion here. I think \
> > I prefer the old widgets over the treeview, so I don't see this as an \
> > improvement... But if you want to have a treeview, I won't fight for that ;-)
>
> Kåre Särs wrote:
> OK I'll add the default target action to build the current target-set default.
>
> The tree view lets me navigate targets and target-sets in one control in stead of \
> many....
If it's all in one treeview, how is the "current" target set determined ?
Also, the target-selection dialog now lists the targets from all target sets. IMO it \
should list only those from the current target set.
Or maybe add a switch/checkbox to switch between "manual" targets and targets from \
the project plugin ? So instead of having a combobox for selecting the target sets, \
and everything separated, and instead of having everything together in one big tree, \
basically have two trees, and switch between them ? This would be good enough for me.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117338/#review55993
-----------------------------------------------------------
On April 5, 2014, 8:44 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117338/
> -----------------------------------------------------------
>
> (Updated April 5, 2014, 8:44 p.m.)
>
>
> Review request for Kate and Alexander Neundorf.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Move the build commands to a model. Modify and access them through
> the model-view interface.
>
> Simplify the access mechanism so that we only have:
> "build target" which opens the target selection dialog
> "build previous" that builds the previous or opens the target selection if there is \
> no previous target "stop" for stopping a running build
> "next error" for jumping to the errors
> "previous error" for jumping to the errors
>
>
> Diffs
> -----
>
> addons/kate/katebuild-plugin/CMakeLists.txt 87a20e3
> addons/kate/katebuild-plugin/SelectTargetUi.ui PRE-CREATION
> addons/kate/katebuild-plugin/SelectTargetView.h PRE-CREATION
> addons/kate/katebuild-plugin/SelectTargetView.cpp PRE-CREATION
> addons/kate/katebuild-plugin/TargetHtmlDelegate.h PRE-CREATION
> addons/kate/katebuild-plugin/TargetHtmlDelegate.cpp PRE-CREATION
> addons/kate/katebuild-plugin/TargetModel.h PRE-CREATION
> addons/kate/katebuild-plugin/TargetModel.cpp PRE-CREATION
> addons/kate/katebuild-plugin/UrlInserter.h PRE-CREATION
> addons/kate/katebuild-plugin/UrlInserter.cpp PRE-CREATION
> addons/kate/katebuild-plugin/plugin_katebuild.h fc47471
> addons/kate/katebuild-plugin/plugin_katebuild.cpp eac9ce1
> addons/kate/katebuild-plugin/selecttargetdialog.h 59baa57
> addons/kate/katebuild-plugin/selecttargetdialog.cpp 5ff5d14
> addons/kate/katebuild-plugin/targets.h 27b3db2
> addons/kate/katebuild-plugin/targets.cpp fda1536
> addons/kate/katebuild-plugin/ui.rc 0d95375
>
> Diff: https://git.reviewboard.kde.org/r/117338/diff/
>
>
> Testing
> -------
>
> Using it at work
>
>
> File Attachments
> ----------------
>
> KF5 port
> https://git.reviewboard.kde.org/media/uploaded/files/2014/04/05/3bd3b19e-4500-438c-9b73-006f29b87812__build_plugin_treeView.patch
>
>
> Thanks,
>
> Kåre Särs
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117338/">https://git.reviewboard.kde.org/r/117338/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 17th, 2014, 8:18 p.m. UTC, <b>Alexander \
Neundorf</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't like that the "build default target" action has \
been removed. Being able to just build the whole thing is good. I don't mind \
removing the special support for the "clean" target.
Whether treeview or combobox+list... I don't have a strong opinion here. I think \
I prefer the old widgets over the treeview, so I don't see this as an \
improvement... But if you want to have a treeview, I won't fight for that \
;-)</pre> </blockquote>
<p>On April 18th, 2014, 8:49 a.m. UTC, <b>Kåre Särs</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK I'll add the \
default target action to build the current target-set default.
The tree view lets me navigate targets and target-sets in one control in stead of \
many.... </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it's all in one \
treeview, how is the "current" target set determined ?
Also, the target-selection dialog now lists the targets from all target sets. IMO it \
should list only those from the current target set.
Or maybe add a switch/checkbox to switch between "manual" targets and \
targets from the project plugin ? So instead of having a combobox for selecting the \
target sets, and everything separated, and instead of having everything together in \
one big tree, basically have two trees, and switch between them ? This would be good \
enough for me.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On April 5th, 2014, 8:44 p.m. UTC, Kåre Särs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Alexander Neundorf.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated April 5, 2014, 8:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Move the build commands to a model. Modify and access them through the \
model-view interface.
Simplify the access mechanism so that we only have:
"build target" which opens the target selection dialog
"build previous" that builds the previous or opens the target selection if \
there is no previous target "stop" for stopping a running build
"next error" for jumping to the errors
"previous error" for jumping to the errors
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using it at work</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/katebuild-plugin/CMakeLists.txt <span style="color: \
grey">(87a20e3)</span></li>
<li>addons/kate/katebuild-plugin/SelectTargetUi.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/SelectTargetView.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/SelectTargetView.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/TargetHtmlDelegate.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/TargetHtmlDelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/TargetModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/TargetModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/UrlInserter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/UrlInserter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/katebuild-plugin/plugin_katebuild.h <span style="color: \
grey">(fc47471)</span></li>
<li>addons/kate/katebuild-plugin/plugin_katebuild.cpp <span style="color: \
grey">(eac9ce1)</span></li>
<li>addons/kate/katebuild-plugin/selecttargetdialog.h <span style="color: \
grey">(59baa57)</span></li>
<li>addons/kate/katebuild-plugin/selecttargetdialog.cpp <span style="color: \
grey">(5ff5d14)</span></li>
<li>addons/kate/katebuild-plugin/targets.h <span style="color: \
grey">(27b3db2)</span></li>
<li>addons/kate/katebuild-plugin/targets.cpp <span style="color: \
grey">(fda1536)</span></li>
<li>addons/kate/katebuild-plugin/ui.rc <span style="color: \
grey">(0d95375)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117338/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/05/3bd3b19e-4500-438c-9b73-006f29b87812__build_plugin_treeView.patch">KF5 \
port</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic