'Re: Review Request 115928: Auto-adapt hardcoded colors to current color scheme'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115928: Auto-adapt hardcoded colors to current color scheme
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2014-02-26 19:31:14
Message-ID: 20140226193114.31541.87674 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115928/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 7:31 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Christoph Cullmann.

Repository: kate

Description
-------

    This code is used like that for years in KDevelop and works quite
    nicely for most cases.

    Note that for darker color schemes, this most often results in
    a bit less-intense colors which is not a big problem as colors stand
    out much more against a dark background. And its better than before,
    where you'd end up with hard-coded colors for a bright background
    scheme...

    Bright color schemes are not affected, as long as they fulfill the
    conditition of having a lower luma for the background color compared
    to the foreground color.

Diffs
-----

  part/syntax/katehighlight.cpp 1ae649d 
  part/utils/katedefaultcolors.h 19fc2f9 
  part/utils/katedefaultcolors.cpp bb1c60b 

Diff: https://git.reviewboard.kde.org/r/115928/diff/

Testing
-------

Created a new kate scheme with a dark and with a bright system color scheme. The \
bright one stayed as-is. The dark one auto-adapted all colors - even those hardcoded \
in highlighting .xml files!

The result is an always-readable text on dark schemes, where previously hard coded \
colors lead to unreadable mess which one had to fix manually...

File Attachments
----------------

LaTeX without adaption
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/aea5478c-0cf8-4dfe-9f4f-350faf2db5f6__kate-no-adapt-latex.png
 LaTeX with adaption
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/a1fcec62-1815-4874-964e-58d3ae240606__kate-auto-adapt-latex.png

Thanks,

Milian Wolff

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115928/">https://git.reviewboard.kde.org/r/115928/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Milian Wolff.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2014, 7:31 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    This code is used like that for years in KDevelop and works quite  \
nicely for most cases.  
    Note that for darker color schemes, this most often results in
    a bit less-intense colors which is not a big problem as colors stand
    out much more against a dark background. And its better than before,
    where you&#39;d end up with hard-coded colors for a bright background
    scheme...

    Bright color schemes are not affected, as long as they fulfill the
    conditition of having a lower luma for the background color compared
    to the foreground color.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created a new kate scheme with a dark and with a bright system color \
scheme. The bright one stayed as-is. The dark one auto-adapted all colors - even \
those hardcoded in highlighting .xml files!

The result is an always-readable text on dark schemes, where previously hard coded \
colors lead to unreadable mess which one had to fix manually...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/katehighlight.cpp <span style="color: grey">(1ae649d)</span></li>

 <li>part/utils/katedefaultcolors.h <span style="color: grey">(19fc2f9)</span></li>

 <li>part/utils/katedefaultcolors.cpp <span style="color: grey">(bb1c60b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115928/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/aea5478c-0cf8-4dfe-9f4f-350faf2db5f6__kate-no-adapt-latex.png">LaTeX \
without adaption</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/a1fcec62-1815-4874-964e-58d3ae240606__kate-auto-adapt-latex.png">LaTeX \
with adaption</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 