--===============1580355636396259300== Content-Type: multipart/alternative; boundary="===============6495419025721064087==" --===============6495419025721064087== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115928/ ----------------------------------------------------------- (Updated Feb. 26, 2014, 7:31 p.m.) Status ------ This change has been marked as submitted. Review request for Kate and Christoph Cullmann. Repository: kate Description ------- This code is used like that for years in KDevelop and works quite nicely for most cases. Note that for darker color schemes, this most often results in a bit less-intense colors which is not a big problem as colors stand out much more against a dark background. And its better than before, where you'd end up with hard-coded colors for a bright background scheme... Bright color schemes are not affected, as long as they fulfill the conditition of having a lower luma for the background color compared to the foreground color. Diffs ----- part/syntax/katehighlight.cpp 1ae649d part/utils/katedefaultcolors.h 19fc2f9 part/utils/katedefaultcolors.cpp bb1c60b Diff: https://git.reviewboard.kde.org/r/115928/diff/ Testing ------- Created a new kate scheme with a dark and with a bright system color scheme. The bright one stayed as-is. The dark one auto-adapted all colors - even those hardcoded in highlighting .xml files! The result is an always-readable text on dark schemes, where previously hard coded colors lead to unreadable mess which one had to fix manually... File Attachments ---------------- LaTeX without adaption https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/aea5478c-0cf8-4dfe-9f4f-350faf2db5f6__kate-no-adapt-latex.png LaTeX with adaption https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/a1fcec62-1815-4874-964e-58d3ae240606__kate-auto-adapt-latex.png Thanks, Milian Wolff --===============6495419025721064087== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115928/

This change has been marked as submitted.

Review request for Kate and Christoph Cullmann.
By Milian Wolff.

Updated Feb. 26, 2014, 7:31 p.m.

Repository: kate

Description 

    This code is used like that for years in KDevelop and works quite
    nicely for most cases.
    
    Note that for darker color schemes, this most often results in
    a bit less-intense colors which is not a big problem as colors stand
    out much more against a dark background. And its better than before,
    where you'd end up with hard-coded colors for a bright background
    scheme...
    
    Bright color schemes are not affected, as long as they fulfill the
    conditition of having a lower luma for the background color compared
    to the foreground color.

Testing 

Created a new kate scheme with a dark and with a bright system color scheme. The bright one stayed as-is. The dark one auto-adapted all colors - even those hardcoded in highlighting .xml files!

The result is an always-readable text on dark schemes, where previously hard coded colors lead to unreadable mess which one had to fix manually...

Diffs

  • part/syntax/katehighlight.cpp (1ae649d)
  • part/utils/katedefaultcolors.h (19fc2f9)
  • part/utils/katedefaultcolors.cpp (bb1c60b)

View Diff

File Attachments

--===============6495419025721064087==-- --===============1580355636396259300== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============1580355636396259300==--