[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115080: move spellcheck dialog to bottomViewBar
From: "Christoph Cullmann" <cullmann () kde ! org>
Date: 2014-02-25 19:16:16
Message-ID: 20140225191616.11047.70596 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 11, 2014, 8:47 a.m., Dominik Haumann wrote:
> > To me this patch looks good and I'd be fine with committing this. The only open \
> > issue is: The code from Sonnet is LGPLv2.1+, and the rest of Kate Part's source \
> > code is LGPLv2+.
> > @Christoph: What's your take on this?
I am ok with that, if 2.1+ or 2+, I guess that is even unclear with the current code.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115080/#review49507
-----------------------------------------------------------
On Feb. 20, 2014, 10:30 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115080/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 10:30 p.m.)
>
>
> Review request for Kate and Christoph Cullmann.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Code transforms the Sonnet::Dialog on top of ViewBarWidget. Currently the design is \
> three lines high. For previous discussion, see review #114675.
>
> Diffs
> -----
>
> src/CMakeLists.txt 770dc39
> src/spellcheck/spellcheckbar.h PRE-CREATION
> src/spellcheck/spellcheckbar.cpp PRE-CREATION
> src/spellcheck/spellcheckbar.ui PRE-CREATION
> src/spellcheck/spellcheckdialog.h 832afcb
> src/spellcheck/spellcheckdialog.cpp bf23b9d
>
> Diff: https://git.reviewboard.kde.org/r/115080/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115080/">https://git.reviewboard.kde.org/r/115080/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 11th, 2014, 8:47 a.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To me this patch looks good and I'd be fine with committing this. \
The only open issue is: The code from Sonnet is LGPLv2.1+, and the rest of Kate \
Part's source code is LGPLv2+.
@Christoph: What's your take on this?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am ok with that, if \
2.1+ or 2+, I guess that is even unclear with the current code.</pre> <br />
<p>- Christoph</p>
<br />
<p>On February 20th, 2014, 10:30 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 10:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code transforms the Sonnet::Dialog on top of ViewBarWidget. Currently \
the design is three lines high. For previous discussion, see review #114675.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(770dc39)</span></li>
<li>src/spellcheck/spellcheckbar.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/spellcheck/spellcheckbar.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/spellcheck/spellcheckbar.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/spellcheck/spellcheckdialog.h <span style="color: \
grey">(832afcb)</span></li>
<li>src/spellcheck/spellcheckdialog.cpp <span style="color: \
grey">(bf23b9d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115080/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic