'Re: Review Request 115944: Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plug'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115944: Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plug
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2014-02-24 21:13:38
Message-ID: 20140224211338.14197.56573 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115944/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 9:13 p.m.)

Review request for Kate.

Changes
-------

Use midRef and QLatin1Sting in stead of checking fist letter and then comparing a bunch of stuff ;)

I was/am trying to follow the coding style of the rest of the file....

+ better handling of multiple properties on the same line

Repository: kate

Description
-------

Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin.

This patch will search for a line containing "id:" and add the name as a "class"

Diffs (updated)
-----

  addons/kate/symbolviewer/ecma_parser.cpp 2b96b0d 
  addons/kate/symbolviewer/plugin_katesymbolviewer.cpp 701f175 

Diff: https://git.reviewboard.kde.org/r/115944/diff/

Testing
-------

Opened a couple of QML files

Thanks,

Kåre Särs

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115944/">https://git.reviewboard.kde.org/r/115944/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Kåre Särs.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2014, 9:13 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use midRef and QLatin1Sting in stead of checking fist letter and then \
comparing a bunch of stuff ;)

I was/am trying to follow the coding style of the rest of the file....

+ better handling of multiple properties on the same line</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add QML and QML-&quot;id:&quot; support to the ecma_parser of the \
SymbolViewer plugin.

This patch will search for a line containing &quot;id:&quot; and add the name as a \
&quot;class&quot;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Opened a couple of QML files</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/kate/symbolviewer/ecma_parser.cpp <span style="color: \
grey">(2b96b0d)</span></li>

 <li>addons/kate/symbolviewer/plugin_katesymbolviewer.cpp <span style="color: \
grey">(701f175)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115944/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 