From kwrite-devel Mon Feb 24 21:13:38 2014 From: =?utf-8?b?S8OlcmUgU8OkcnM=?= Date: Mon, 24 Feb 2014 21:13:38 +0000 To: kwrite-devel Subject: Re: Review Request 115944: Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plug Message-Id: <20140224211338.14197.56573 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139327642901072 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3057986099785665062==" --===============3057986099785665062== Content-Type: multipart/alternative; boundary="===============6908663383525911379==" --===============6908663383525911379== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115944/ ----------------------------------------------------------- (Updated Feb. 24, 2014, 9:13 p.m.) Review request for Kate. Changes ------- Use midRef and QLatin1Sting in stead of checking fist letter and then comparing a bunch of stuff ;) I was/am trying to follow the coding style of the rest of the file.... + better handling of multiple properties on the same line Repository: kate Description ------- Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin. This patch will search for a line containing "id:" and add the name as a "class" Diffs (updated) ----- addons/kate/symbolviewer/ecma_parser.cpp 2b96b0d addons/kate/symbolviewer/plugin_katesymbolviewer.cpp 701f175 Diff: https://git.reviewboard.kde.org/r/115944/diff/ Testing ------- Opened a couple of QML files Thanks, Kåre Särs --===============6908663383525911379== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115944/

Review request for Kate.

By Kåre Särs.

Updated Feb. 24, 2014, 9:13 p.m.

Changes

Use midRef and QLatin1Sting in stead of checking fist letter and then comparing a bunch of stuff ;)

I was/am trying to follow the coding style of the rest of the file....

+ better handling of multiple properties on the same line

Repository: kate

Description

Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin.

This patch will search for a line containing "id:" and add the name as a "class"

Testing

Opened a couple of QML files

Diffs (updated)

addons/kate/symbolviewer/ecma_parser.cpp (2b96b0d)
addons/kate/symbolviewer/plugin_katesymbolviewer.cpp (701f175)

View Diff

--===============6908663383525911379==-- --===============3057986099785665062== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============3057986099785665062==--