[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115873: add replicode plugin
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2014-02-20 9:40:52
Message-ID: 20140220094052.5175.1282 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115873/#review50308
-----------------------------------------------------------
Ship it!
Looks good, if you want, you can commit (fix the memory leak).
Btw: Does it also properly work with multiple main windows? Try View > New Window.
addons/kate/replicode/replicodeconfig.h
<https://git.reviewboard.kde.org/r/115873/#comment35407>
In frameworks 5, we Kate Part and KTextEditor is all LGPLv2+, and Kate is GPLv2+.
If you want, you can change the license to LGPLv2+.
addons/kate/replicode/replicodeconfig.cpp
<https://git.reviewboard.kde.org/r/115873/#comment35408>
Memory leak: you are missing a:
delete m_ui;
- Dominik Haumann
On Feb. 18, 2014, 8:26 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115873/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 8:26 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> adds a plugin for executing the replicode VM directly from Kate, as well as \
> adjusting launch parameters and displaying the output.
>
> Diffs
> -----
>
> addons/kate/CMakeLists.txt 8ff9fff
> addons/kate/replicode/CMakeLists.txt PRE-CREATION
> addons/kate/replicode/config.ui PRE-CREATION
> addons/kate/replicode/katereplicodeplugin.desktop PRE-CREATION
> addons/kate/replicode/replicodeconfig.h PRE-CREATION
> addons/kate/replicode/replicodeconfig.cpp PRE-CREATION
> addons/kate/replicode/replicodeconfigpage.h PRE-CREATION
> addons/kate/replicode/replicodeconfigpage.cpp PRE-CREATION
> addons/kate/replicode/replicodeplugin.h PRE-CREATION
> addons/kate/replicode/replicodeplugin.cpp PRE-CREATION
> addons/kate/replicode/replicodesettings.h PRE-CREATION
> addons/kate/replicode/replicodesettings.cpp PRE-CREATION
> addons/kate/replicode/replicodeview.h PRE-CREATION
> addons/kate/replicode/ui.rc PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115873/">https://git.reviewboard.kde.org/r/115873/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, if you want, \
you can commit (fix the memory leak).
Btw: Does it also properly work with multiple main windows? Try View > New \
Window.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115873/diff/3/?file=244849#file244849line4" \
style="color: black; font-weight: bold; text-decoration: \
underline;">addons/kate/replicode/replicodeconfig.h</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">4</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> This library is free software; you can redistribute it \
and/or</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In \
frameworks 5, we Kate Part and KTextEditor is all LGPLv2+, and Kate is GPLv2+.
If you want, you can change the license to LGPLv2+.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115873/diff/3/?file=244850#file244850line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">addons/kate/replicode/replicodeconfig.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Memory \
leak: you are missing a:
delete m_ui;</pre>
</div>
<br />
<p>- Dominik Haumann</p>
<br />
<p>On February 18th, 2014, 8:26 p.m. UTC, Martin Tobias Holmedahl Sandsmark \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2014, 8:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">adds a plugin for executing the replicode VM directly from Kate, as well \
as adjusting launch parameters and displaying the output.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/CMakeLists.txt <span style="color: grey">(8ff9fff)</span></li>
<li>addons/kate/replicode/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/config.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/katereplicodeplugin.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeconfigpage.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeconfigpage.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodesettings.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodesettings.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/replicodeview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/replicode/ui.rc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115873/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic