'Re: Review Request 115899: Improve build plugin layout in vertical mode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115899: Improve build plugin layout in vertical mode
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2014-02-20 7:32:29
Message-ID: 20140220073229.1865.43040 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115899/#review50305
-----------------------------------------------------------

Ship it!

That is a different approach than what I used, but I think it is better :)

- Kåre Särs

On Feb. 19, 2014, 8:57 p.m., Alexander Neundorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115899/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 8:57 p.m.)
> 
> 
> Review request for Kate and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> The attached patch adds a second set of the new buttons and status label on a \
> separate line in the vbox layout, and depending on the current width of the widget \
> one of the two sets is made visible. 
> 
> Diffs
> -----
> 
> addons/kate/katebuild-plugin/build.ui 775d666 
> addons/kate/katebuild-plugin/plugin_katebuild.h 197a8ce 
> addons/kate/katebuild-plugin/plugin_katebuild.cpp d4fbe08 
> 
> Diff: https://git.reviewboard.kde.org/r/115899/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Neundorf
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115899/">https://git.reviewboard.kde.org/r/115899/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is a different \
approach than what I used, but I think it is better :)</pre>  <br />

<p>- Kåre Särs</p>

<br />
<p>On February 19th, 2014, 8:57 p.m. UTC, Alexander Neundorf wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Kåre Särs.</div>
<div>By Alexander Neundorf.</div>

<p style="color: grey;"><i>Updated Feb. 19, 2014, 8:57 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch adds a second set of the new buttons and status label \
on a separate line in the vbox layout, and depending on the current width of the \
widget one of the two sets is made visible. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/kate/katebuild-plugin/build.ui <span style="color: \
grey">(775d666)</span></li>

 <li>addons/kate/katebuild-plugin/plugin_katebuild.h <span style="color: \
grey">(197a8ce)</span></li>

 <li>addons/kate/katebuild-plugin/plugin_katebuild.cpp <span style="color: \
grey">(d4fbe08)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115899/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 