'Re: Review Request 115845: syntax: add ability to specify LineContinu character'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115845: syntax: add ability to specify LineContinu character
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2014-02-18 6:33:25
Message-ID: 20140218063325.430.29853 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115845/
-----------------------------------------------------------

(Updated Feb. 18, 2014, 6:33 a.m.)

Review request for Kate.

Repository: kate

Description
-------

This enables to use different LineContinue character other then C-like '\\'.

Should there be some additional test for this?

Diffs (updated)
-----

  doc/kate/highlighting.docbook 7706887 
  part/syntax/data/language.dtd a86d51f 
  part/syntax/katehighlight.cpp 1a3abfa 
  part/syntax/katehighlighthelpers.h 24daf7c 
  part/syntax/katehighlighthelpers.cpp 9528fb1 

Diff: https://git.reviewboard.kde.org/r/115845/diff/

Testing
-------

Used in own highlight file, seems to be working. The C syntax seems to be working still:)

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115845/">https://git.reviewboard.kde.org/r/115845/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Feb. 18, 2014, 6:33 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This enables to use different LineContinue character other then C-like \
&#39;\\&#39;.

Should there be some additional test for this?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used in own highlight file, seems to be working. The C syntax seems to \
be working still:)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>doc/kate/highlighting.docbook <span style="color: grey">(7706887)</span></li>

 <li>part/syntax/data/language.dtd <span style="color: grey">(a86d51f)</span></li>

 <li>part/syntax/katehighlight.cpp <span style="color: grey">(1a3abfa)</span></li>

 <li>part/syntax/katehighlighthelpers.h <span style="color: \
grey">(24daf7c)</span></li>

 <li>part/syntax/katehighlighthelpers.cpp <span style="color: \
grey">(9528fb1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115845/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 