[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115845: syntax: add ability to specify LineContinu character
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2014-02-17 21:50:46
Message-ID: 20140217215046.9975.21677 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115845/#review50108
-----------------------------------------------------------
doc/kate/highlighting.docbook
<https://git.reviewboard.kde.org/r/115845/#comment35219>
Can you make this:
<programlisting><LineContinue (common attributes) [char="\"] /></programlisting>
So that it's clear how the syntax looks like? Besides that, not objections.
- Dominik Haumann
On Feb. 17, 2014, 9:22 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115845/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 9:22 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This enables to use different LineContinue character other then C-like '\\'.
>
> Should there be some additional test for this?
>
>
> Diffs
> -----
>
> doc/kate/highlighting.docbook 7706887
> part/syntax/data/language.dtd a86d51f
> part/syntax/katehighlight.cpp 1a3abfa
> part/syntax/katehighlighthelpers.h 24daf7c
> part/syntax/katehighlighthelpers.cpp 9528fb1
>
> Diff: https://git.reviewboard.kde.org/r/115845/diff/
>
>
> Testing
> -------
>
> Used in own highlight file, seems to be working. The C syntax seems to be working still:)
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115845/">https://git.reviewboard.kde.org/r/115845/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115845/diff/2/?file=244678#file244678line831" \
style="color: black; font-weight: bold; text-decoration: \
underline;">doc/kate/highlighting.docbook</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">831</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; \
"><programlisting>&lt;LineContinue (common attributes) \
/&gt;</programlisting></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">831</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; \
"><programlisting>&lt;LineContinue (common attributes) \
/&gt;</programlisting></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you \
make this: <programlisting>&lt;LineContinue (common attributes) \
[char="\"] /&gt;</programlisting>
So that it's clear how the syntax looks like? Besides that, not objections.</pre>
</div>
<br />
<p>- Dominik Haumann</p>
<br />
<p>On February 17th, 2014, 9:22 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2014, 9:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This enables to use different LineContinue character other then C-like \
'\\'.
Should there be some additional test for this?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used in own highlight file, seems to be working. The C syntax seems to \
be working still:)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/kate/highlighting.docbook <span style="color: grey">(7706887)</span></li>
<li>part/syntax/data/language.dtd <span style="color: grey">(a86d51f)</span></li>
<li>part/syntax/katehighlight.cpp <span style="color: grey">(1a3abfa)</span></li>
<li>part/syntax/katehighlighthelpers.h <span style="color: \
grey">(24daf7c)</span></li>
<li>part/syntax/katehighlighthelpers.cpp <span style="color: \
grey">(9528fb1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115845/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic