'Re: Review Request 115544: fix field highlighting in reStructuredText'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115544: fix field highlighting in reStructuredText
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2014-02-10 18:30:39
Message-ID: 20140210183039.2492.99111 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115544/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 1:30 p.m.)

Review request for Kate and Stephen Kelly.

Repository: kate

Description
-------

Swap order of field and role rules, as the latter was overriding the former and \
causing it to never fire. Change field detection to a regex with a stricter rule as \
to what comprises a "field" (specifically, to prevent a role at the beginning of a \
line from being interpreted as a field). Add support for inline markup in fields.

@skelly, I noticed you don't have a copyright/authorship line here... should you?

Diffs
-----

  .gitlog PRE-CREATION 
  part/syntax/data/rest.xml 76c476a7a1f0b774ccabf0f48a518b413b9e63e4 

Diff: https://git.reviewboard.kde.org/r/115544/diff/

Testing (updated)
-------

Test Content
------------

> This: ...is a field.
> This:
  ...is also a field.

> role:`ref` is not a field.
Nor is :role:`ref`.

> An *exciting* field: isn't it, though?
> A ``literal`` like this: is often used in e.g. CMake documentation.

Thanks,

Matthew Woehlke

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115544/">https://git.reviewboard.kde.org/r/115544/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Stephen Kelly.</div>
<div>By Matthew Woehlke.</div>

<p style="color: grey;"><i>Updated Feb. 10, 2014, 1:30 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Swap order of field and role rules, as the latter was overriding the \
former and causing it to never fire. Change field detection to a regex with a \
stricter rule as to what comprises a &quot;field&quot; (specifically, to prevent a \
role at the beginning of a line from being interpreted as a field). Add support for \
inline markup in fields.

@skelly, I noticed you don&#39;t have a copyright/authorship line here... should \
you?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Test Content
------------

> This: ...is a field.
> This:
  ...is also a field.

> role:`ref` is not a field.
Nor is :role:`ref`.

> An *exciting* field: isn&#39;t it, though?
> A ``literal`` like this: is often used in e.g. CMake documentation.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>.gitlog <span style="color: grey">(PRE-CREATION)</span></li>

 <li>part/syntax/data/rest.xml <span style="color: \
grey">(76c476a7a1f0b774ccabf0f48a518b413b9e63e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115544/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 