From kwrite-devel Mon Feb 10 18:30:39 2014 From: "Matthew Woehlke" Date: Mon, 10 Feb 2014 18:30:39 +0000 To: kwrite-devel Subject: Re: Review Request 115544: fix field highlighting in reStructuredText Message-Id: <20140210183039.2492.99111 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139205705105800 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3044992588420697187==" --===============3044992588420697187== Content-Type: multipart/alternative; boundary="===============8142119969608091024==" --===============8142119969608091024== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115544/ ----------------------------------------------------------- (Updated Feb. 10, 2014, 1:30 p.m.) Review request for Kate and Stephen Kelly. Repository: kate Description ------- Swap order of field and role rules, as the latter was overriding the former and causing it to never fire. Change field detection to a regex with a stricter rule as to what comprises a "field" (specifically, to prevent a role at the beginning of a line from being interpreted as a field). Add support for inline markup in fields. @skelly, I noticed you don't have a copyright/authorship line here... should you? Diffs ----- .gitlog PRE-CREATION part/syntax/data/rest.xml 76c476a7a1f0b774ccabf0f48a518b413b9e63e4 Diff: https://git.reviewboard.kde.org/r/115544/diff/ Testing (updated) ------- Test Content ------------ :This: ...is a field. :This: ...is also a field. :role:`ref` is not a field. Nor is :role:`ref`. :An *exciting* field: isn't it, though? :A ``literal`` like this: is often used in e.g. CMake documentation. Thanks, Matthew Woehlke --===============8142119969608091024== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115544/

Review request for Kate and Stephen Kelly.
By Matthew Woehlke.

Updated Feb. 10, 2014, 1:30 p.m.

Repository: kate

Description 

Swap order of field and role rules, as the latter was overriding the former and causing it to never fire. Change field detection to a regex with a stricter rule as to what comprises a "field" (specifically, to prevent a role at the beginning of a line from being interpreted as a field). Add support for inline markup in fields.

@skelly, I noticed you don't have a copyright/authorship line here... should you?

Testing (updated)

Test Content
------------

:This: ...is a field.
:This:
  ...is also a field.

:role:`ref` is not a field.
Nor is :role:`ref`.

:An *exciting* field: isn't it, though?
:A ``literal`` like this: is often used in e.g. CMake documentation.

Diffs

  • .gitlog (PRE-CREATION)
  • part/syntax/data/rest.xml (76c476a7a1f0b774ccabf0f48a518b413b9e63e4)

View Diff
--===============8142119969608091024==-- --===============3044992588420697187== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============3044992588420697187==--