[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114229: frameworks: add posibility to change swap file location
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2013-12-28 14:48:27
Message-ID: 20131228144827.18800.79713 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114229/
-----------------------------------------------------------
(Updated Dec. 28, 2013, 2:48 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate.
Bugs: 321135 and 328244
http://bugs.kde.org/show_bug.cgi?id=321135
http://bugs.kde.org/show_bug.cgi?id=328244
Repository: kate
Description
-------
Single purpose of this patch is to have something more than idea for disccussion.
The main idea is to put kate-swp files to a different place then original document in case the \
document is on "slow" remote FS (sshfs, afs, ...).
The config ui is a little bit rought. The md5 sum might represent a collision problem. Not sure \
if it makes sense to add third option: "Turn Swapping Off", a.k.a. how essential is for a text \
editor to keep "swap" files?
Diffs
-----
part/dialogs/katedialogs.h 20ed4c3
part/dialogs/katedialogs.cpp 9c2c4e2
part/dialogs/opensaveconfigadvwidget.ui aead37b
part/document/katedocument.cpp 6a78907
part/swapfile/kateswapfile.cpp ec67665
part/utils/kateconfig.h aabedd3
part/utils/kateconfig.cpp db28b68
Diff: https://git.reviewboard.kde.org/r/114229/diff/
Testing
-------
Thanks,
Michal Humpula
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114229/">https://git.reviewboard.kde.org/r/114229/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 2:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=321135">321135</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=328244">328244</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Single purpose of \
this patch is to have something more than idea for disccussion.
The main idea is to put kate-swp files to a different place then original document in case the \
document is on "slow" remote FS (sshfs, afs, ...).
The config ui is a little bit rought. The md5 sum might represent a collision problem. Not sure \
if it makes sense to add third option: "Turn Swapping Off", a.k.a. how essential is \
for a text editor to keep "swap" files?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/dialogs/katedialogs.h <span style="color: grey">(20ed4c3)</span></li>
<li>part/dialogs/katedialogs.cpp <span style="color: grey">(9c2c4e2)</span></li>
<li>part/dialogs/opensaveconfigadvwidget.ui <span style="color: grey">(aead37b)</span></li>
<li>part/document/katedocument.cpp <span style="color: grey">(6a78907)</span></li>
<li>part/swapfile/kateswapfile.cpp <span style="color: grey">(ec67665)</span></li>
<li>part/utils/kateconfig.h <span style="color: grey">(aabedd3)</span></li>
<li>part/utils/kateconfig.cpp <span style="color: grey">(db28b68)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114229/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic