From kwrite-devel Sat Dec 28 14:48:27 2013 From: "Michal Humpula" Date: Sat, 28 Dec 2013 14:48:27 +0000 To: kwrite-devel Subject: Re: Review Request 114229: frameworks: add posibility to change swap file location Message-Id: <20131228144827.18800.79713 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138824213209321 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0089907856485374740==" --===============0089907856485374740== Content-Type: multipart/alternative; boundary="===============6325455288121415012==" --===============6325455288121415012== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114229/ ----------------------------------------------------------- (Updated Dec. 28, 2013, 2:48 p.m.) Status ------ This change has been marked as submitted. Review request for Kate. Bugs: 321135 and 328244 http://bugs.kde.org/show_bug.cgi?id=321135 http://bugs.kde.org/show_bug.cgi?id=328244 Repository: kate Description ------- Single purpose of this patch is to have something more than idea for disccussion. The main idea is to put kate-swp files to a different place then original document in case the document is on "slow" remote FS (sshfs, afs, ...). The config ui is a little bit rought. The md5 sum might represent a collision problem. Not sure if it makes sense to add third option: "Turn Swapping Off", a.k.a. how essential is for a text editor to keep "swap" files? Diffs ----- part/dialogs/katedialogs.h 20ed4c3 part/dialogs/katedialogs.cpp 9c2c4e2 part/dialogs/opensaveconfigadvwidget.ui aead37b part/document/katedocument.cpp 6a78907 part/swapfile/kateswapfile.cpp ec67665 part/utils/kateconfig.h aabedd3 part/utils/kateconfig.cpp db28b68 Diff: https://git.reviewboard.kde.org/r/114229/diff/ Testing ------- Thanks, Michal Humpula --===============6325455288121415012== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114229/

This change has been marked as submitted.

Review request for Kate.
By Michal Humpula.

Updated Dec. 28, 2013, 2:48 p.m.

Bugs: 321135, 328244
Repository: kate

Description 

Single purpose of this patch is to have something more than idea for disccussion.

The main idea is to put kate-swp files to a different place then original document in case the document is on "slow" remote FS (sshfs, afs, ...).

The config ui is a little bit rought. The md5 sum might represent a collision problem. Not sure if it makes sense to add third option: "Turn Swapping Off", a.k.a. how essential is for a text editor to keep "swap" files?

Diffs

  • part/dialogs/katedialogs.h (20ed4c3)
  • part/dialogs/katedialogs.cpp (9c2c4e2)
  • part/dialogs/opensaveconfigadvwidget.ui (aead37b)
  • part/document/katedocument.cpp (6a78907)
  • part/swapfile/kateswapfile.cpp (ec67665)
  • part/utils/kateconfig.h (aabedd3)
  • part/utils/kateconfig.cpp (db28b68)

View Diff
--===============6325455288121415012==-- --===============0089907856485374740== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0089907856485374740==--