[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114395: add partial RST support to cmake.xml
From: "Christoph Cullmann" <cullmann () kde ! org>
Date: 2013-12-26 19:10:17
Message-ID: 20131226191017.4851.40491 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 14, 2013, 7:58 p.m., Dominik Haumann wrote:
> > Matthew, you've been working a lot with the highlighting system. I trust you know \
> > what you are doing. The patch looks good, so please commit.
>
> Matthew Woehlke wrote:
> Thanks. On further thought, however, my "reservation" is that this syntax is only \
> valid for the upcoming 3.0 release. Also, there are some other places that bracket \
> quoting should be supported. I added that locally and can re-upload, but I wonder \
> if it's okay to go ahead and commit all of it, or if it should wait until CMake 3.0 \
> is released? Or should just the RST support be added for now?
> (Actually, I'll go ahead and push everything to mwoehlke/cmake-3.0-syntax-support \
> but not update the review yet pending your thoughts on the above.)
Just add it.
CMake 3.0 is not that far away and it won't disturb CMake 2.x users, at least not me \
;)
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114395/#review45701
-----------------------------------------------------------
On Dec. 10, 2013, 10:20 p.m., Matthew Woehlke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114395/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 10:20 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Add support for quoted RST in CMake. Only quoted is supported because the other \
> syntax can't be trivially highlighted, as it relies on implicit removal of the \
> leading comment character.
>
> Diffs
> -----
>
> part/syntax/data/cmake.xml a7dcebc21fa250d3b7fbf20e7951e499f73b2ea2
>
> Diff: https://git.reviewboard.kde.org/r/114395/diff/
>
>
> Testing
> -------
>
> Tried adding some RST blocks on a CMake file; highlighting is as expected.
>
>
> Thanks,
>
> Matthew Woehlke
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114395/">https://git.reviewboard.kde.org/r/114395/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 14th, 2013, 7:58 p.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Matthew, you've been working a lot with the highlighting system. I \
trust you know what you are doing. The patch looks good, so please commit.</pre> \
</blockquote>
<p>On December 16th, 2013, 5:07 p.m. UTC, <b>Matthew Woehlke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. On further \
thought, however, my "reservation" is that this syntax is only valid for \
the upcoming 3.0 release. Also, there are some other places that bracket quoting \
should be supported. I added that locally and can re-upload, but I wonder if it's \
okay to go ahead and commit all of it, or if it should wait until CMake 3.0 is \
released? Or should just the RST support be added for now?
(Actually, I'll go ahead and push everything to mwoehlke/cmake-3.0-syntax-support \
but not update the review yet pending your thoughts on the above.)</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just add it. CMake 3.0 \
is not that far away and it won't disturb CMake 2.x users, at least not me \
;)</pre> <br />
<p>- Christoph</p>
<br />
<p>On December 10th, 2013, 10:20 p.m. UTC, Matthew Woehlke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Matthew Woehlke.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 10:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for quoted RST in CMake. Only quoted is supported because \
the other syntax can't be trivially highlighted, as it relies on implicit removal \
of the leading comment character.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried adding some RST blocks on a CMake file; highlighting is as \
expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/syntax/data/cmake.xml <span style="color: \
grey">(a7dcebc21fa250d3b7fbf20e7951e499f73b2ea2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114395/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic