[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114649: frameworks: filetree sort widget (demo preview)
From: "Christoph Cullmann" <cullmann () kde ! org>
Date: 2013-12-26 17:59:55
Message-ID: 20131226175955.4851.33972 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114649/#review46159
-----------------------------------------------------------
I have no problems with the idea, one point would be: I would rather have more \
LGPLv2+ code in kate app/part than more GPL stuff copied in, if you need to reuse \
that code, might you ask the author if he would be ok with LGPLv2+, too?
- Christoph Cullmann
On Dec. 24, 2013, 3:32 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114649/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2013, 3:32 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> What it is:
> This is a demo preview, please don't spent time in reviewing the code (it's ugly as \
> hell:-)
> From where:
> Shamelessly copied from amarok src (polished and cut down). If you are amarok user, \
> then this is the same as the playlist sorting widget.
> Why:
> The current options for sorting files in filetreeview are quite limited. And if you \
> select one, you can't select the second level order (i.e. sort by extension and \
> then by filename).
> What it does:
> It's functional demo, so it doesn't sort anything. But it shows itself above the \
> tree view and you can select the levels for ordering.
> Why so ugly:
> don't want to spent too much time on it, if it will be rejected anyway. So, please \
> leave a comment if it's desirable thing or not.
>
> Diffs
> -----
>
> kate/filetree/CMakeLists.txt b23b3fd
> kate/filetree/breadcrumbitem.h PRE-CREATION
> kate/filetree/breadcrumbitem.cpp PRE-CREATION
> kate/filetree/breadcrumbitembutton.h PRE-CREATION
> kate/filetree/breadcrumbitembutton.cpp PRE-CREATION
> kate/filetree/breadcrumbitemsortbutton.h PRE-CREATION
> kate/filetree/breadcrumbitemsortbutton.cpp PRE-CREATION
> kate/filetree/breadcrumblevel.h PRE-CREATION
> kate/filetree/breadcrumblevel.cpp PRE-CREATION
> kate/filetree/katefiletreeplugin.cpp 45287db
> kate/filetree/sortwidget.h PRE-CREATION
> kate/filetree/sortwidget.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/114649/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114649/">https://git.reviewboard.kde.org/r/114649/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have no problems with \
the idea, one point would be: I would rather have more LGPLv2+ code in kate app/part \
than more GPL stuff copied in, if you need to reuse that code, might you ask the \
author if he would be ok with LGPLv2+, too?</pre> <br />
<p>- Christoph Cullmann</p>
<br />
<p>On December 24th, 2013, 3:32 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2013, 3:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What it is: This is a demo preview, please don't spent time in \
reviewing the code (it's ugly as hell:-)
From where:
Shamelessly copied from amarok src (polished and cut down). If you are amarok user, \
then this is the same as the playlist sorting widget.
Why:
The current options for sorting files in filetreeview are quite limited. And if you \
select one, you can't select the second level order (i.e. sort by extension and \
then by filename).
What it does:
It's functional demo, so it doesn't sort anything. But it shows itself above \
the tree view and you can select the levels for ordering.
Why so ugly:
don't want to spent too much time on it, if it will be rejected anyway. So, \
please leave a comment if it's desirable thing or not.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/filetree/CMakeLists.txt <span style="color: grey">(b23b3fd)</span></li>
<li>kate/filetree/breadcrumbitem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumbitem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumbitembutton.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumbitembutton.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumbitemsortbutton.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumbitemsortbutton.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumblevel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/breadcrumblevel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/filetree/katefiletreeplugin.cpp <span style="color: \
grey">(45287db)</span></li>
<li>kate/filetree/sortwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kate/filetree/sortwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114649/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic