--===============0880537899074616201== Content-Type: multipart/alternative; boundary="===============1321269809107541093==" --===============1321269809107541093== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114649/#review46159 ----------------------------------------------------------- I have no problems with the idea, one point would be: I would rather have more LGPLv2+ code in kate app/part than more GPL stuff copied in, if you need to reuse that code, might you ask the author if he would be ok with LGPLv2+, too? - Christoph Cullmann On Dec. 24, 2013, 3:32 p.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114649/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2013, 3:32 p.m.) > > > Review request for Kate. > > > Repository: kate > > > Description > ------- > > What it is: > This is a demo preview, please don't spent time in reviewing the code (it's ugly as hell:-) > > From where: > Shamelessly copied from amarok src (polished and cut down). If you are amarok user, then this is the same as the playlist sorting widget. > > Why: > The current options for sorting files in filetreeview are quite limited. And if you select one, you can't select the second level order (i.e. sort by extension and then by filename). > > What it does: > It's functional demo, so it doesn't sort anything. But it shows itself above the tree view and you can select the levels for ordering. > > Why so ugly: > don't want to spent too much time on it, if it will be rejected anyway. So, please leave a comment if it's desirable thing or not. > > > Diffs > ----- > > kate/filetree/CMakeLists.txt b23b3fd > kate/filetree/breadcrumbitem.h PRE-CREATION > kate/filetree/breadcrumbitem.cpp PRE-CREATION > kate/filetree/breadcrumbitembutton.h PRE-CREATION > kate/filetree/breadcrumbitembutton.cpp PRE-CREATION > kate/filetree/breadcrumbitemsortbutton.h PRE-CREATION > kate/filetree/breadcrumbitemsortbutton.cpp PRE-CREATION > kate/filetree/breadcrumblevel.h PRE-CREATION > kate/filetree/breadcrumblevel.cpp PRE-CREATION > kate/filetree/katefiletreeplugin.cpp 45287db > kate/filetree/sortwidget.h PRE-CREATION > kate/filetree/sortwidget.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114649/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > > --===============1321269809107541093== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114649/

I have no problems with the idea, one point would be: I would rather have more LGPLv2+ code in kate app/part than more GPL stuff copied in, if you need to reuse that code, might you ask the author if he would be ok with LGPLv2+, too?

- Christoph Cullmann

On December 24th, 2013, 3:32 p.m. UTC, Michal Humpula wrote:

Review request for Kate.

By Michal Humpula.

Updated Dec. 24, 2013, 3:32 p.m.

Repository: kate

Description

What it is:
This is a demo preview, please don't spent time in reviewing the code (it's ugly as hell:-)

From where:
Shamelessly copied from amarok src (polished and cut down). If you are amarok user, then this is the same as the playlist sorting widget.

Why:
The current options for sorting files in filetreeview are quite limited. And if you select one, you can't select the second level order (i.e. sort by extension and then by filename).

What it does:
It's functional demo, so it doesn't sort anything. But it shows itself above the tree view and you can select the levels for ordering.

Why so ugly:
don't want to spent too much time on it, if it will be rejected anyway. So, please leave a comment if it's desirable thing or not.

Diffs

kate/filetree/CMakeLists.txt (b23b3fd)
kate/filetree/breadcrumbitem.h (PRE-CREATION)
kate/filetree/breadcrumbitem.cpp (PRE-CREATION)
kate/filetree/breadcrumbitembutton.h (PRE-CREATION)
kate/filetree/breadcrumbitembutton.cpp (PRE-CREATION)
kate/filetree/breadcrumbitemsortbutton.h (PRE-CREATION)
kate/filetree/breadcrumbitemsortbutton.cpp (PRE-CREATION)
kate/filetree/breadcrumblevel.h (PRE-CREATION)
kate/filetree/breadcrumblevel.cpp (PRE-CREATION)
kate/filetree/katefiletreeplugin.cpp (45287db)
kate/filetree/sortwidget.h (PRE-CREATION)
kate/filetree/sortwidget.cpp (PRE-CREATION)

--===============1321269809107541093==-- --===============0880537899074616201== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0880537899074616201==--