[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114638: when saving emit documentUrlChanged only when really changed
From:       Michal Humpula <michal.humpula () seznam ! cz>
Date:       2013-12-24 8:01:22
Message-ID: 5382940.RRPRpIECQr () amonsul
[Download RAW message or body]

I don't think that is relevant. IMHO the document url will change only, when 
calling saveAs. Doesn't matter whether the file is local or not.

Relevant parts in KPart are in my knowledge these:

http://api.kde.org/4.x-api/kdelibs-apidocs/kparts/html/part_8cpp_source.html#l00902

http://api.kde.org/frameworks-5.x-api/frameworks-apidocs/kparts/html/part_8cpp_source.html#l00910

Cheers
Michal

On Tuesday 24 of December 2013 08:44:26 Christoph Cullmann wrote:
> Isn't saves asynchronous for non-local files and we do it therefore in that
> way?
> Am 24.12.2013 08:06 schrieb Michal Humpula <michal.humpula@seznam.cz>:
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/114638/
> > 
> > Review request for Kate.
> > By Michal Humpula.
> > Bugs: 329183
> > Repository: kate
> > Description
> > 
> > Couldn't find any other reason, why there should be emit
> > documentUrlChanged() in saveFile other then "saveAs" situation. So this
> > patch moves the emit to more apropriate place.
> > 
> > Testing
> > 
> > make test. Visually it seems that everything is updated after saving, even
> > in the case of a new document.
> > 
> > Diffs
> > part/document/katedocument.cpp (fc22006)
> > 
> > View Diff

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]