[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114638: when saving emit documentUrlChanged only when really changed
From:       Christoph Cullmann <cullmann () absint ! com>
Date:       2013-12-24 7:44:26
Message-ID: 20131224074422.B03584C661AD () mail ! absint ! com
[Download RAW message or body]

Isn't saves asynchronous for non-local files and we do it therefore in that way?

Am 24.12.2013 08:06 schrieb Michal Humpula <michal.humpula@seznam.cz>:
> 
> This is an automatically generated e-mail. To reply, visit: \
> https://git.reviewboard.kde.org/r/114638/ 
> Review request for Kate.
> By Michal Humpula.
> Bugs: 329183
> Repository: kate
> Description
> 
> Couldn't find any other reason, why there should be emit documentUrlChanged() in \
> saveFile other then "saveAs" situation. So this patch moves the emit to more \
> apropriate place. 
> Testing
> 
> make test. Visually it seems that everything is updated after saving, even in the \
> case of a new document. 
> Diffs
> part/document/katedocument.cpp (fc22006)
> 
> View Diff
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]