[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114551: frameworks: port from KIO::NetAccess
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2013-12-23 10:09:37
Message-ID: 20131223100937.18783.99597 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 23, 2013, 8:21 a.m., David Faure wrote:
> > part/document/katedocument.cpp, line 2190
> > <https://git.reviewboard.kde.org/r/114551/diff/1/?file=226646#file226646line2190>
> >
> > backupSuccess = job->exec(); would be shorter, but yeah, this is equivalent.
> > I think it's more readable to see immediately that the return value of exec() is \
> > checked, rather than looking further down for a check on error() [this applies to \
> > the other parts of the patch too].
Thanks for input! I will adjust the places appropriately.
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114551/#review46064
-----------------------------------------------------------
On Dec. 21, 2013, 10:08 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114551/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2013, 10:08 p.m.)
>
>
> Review request for Kate and David Faure.
>
>
> Repository: kate
>
>
> Description
> -------
>
> KIO::NetAccess made it to kde4support, so this is the patch to port from it.
>
> This is my first touch with KIO, so need someone to recheck if it makes sense. Apps \
> are running ok it seems:)
>
> Diffs
> -----
>
> kate/app/katesession.cpp 17d8741
> kwrite/kwritemain.cpp fc14fda
> part/dialogs/katedialogs.cpp c536d3d
> part/document/katedocument.cpp 286c061
>
> Diff: https://git.reviewboard.kde.org/r/114551/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114551/">https://git.reviewboard.kde.org/r/114551/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 23rd, 2013, 8:21 a.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114551/diff/1/?file=226646#file226646line2190" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/document/katedocument.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KateDocument::saveFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2190</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">backupSuccess</span> <span class="o">=</span> <span class="o">!</span><span \
class="n">job</span><span class="o">-></span><span class="n">error</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">backupSuccess = \
job->exec(); would be shorter, but yeah, this is equivalent. I think it's more \
readable to see immediately that the return value of exec() is checked, rather than \
looking further down for a check on error() [this applies to the other parts of the \
patch too].</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for \
input! I will adjust the places appropriately.</pre> <br />
<p>- Michal</p>
<br />
<p>On December 21st, 2013, 10:08 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and David Faure.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2013, 10:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KIO::NetAccess made it to kde4support, so this is the patch to port from \
it.
This is my first touch with KIO, so need someone to recheck if it makes sense. Apps \
are running ok it seems:)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/app/katesession.cpp <span style="color: grey">(17d8741)</span></li>
<li>kwrite/kwritemain.cpp <span style="color: grey">(fc14fda)</span></li>
<li>part/dialogs/katedialogs.cpp <span style="color: grey">(c536d3d)</span></li>
<li>part/document/katedocument.cpp <span style="color: grey">(286c061)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114551/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic