On December 23rd, 2013, 8:21 a.m. UTC, David Faure wrote:

part/document/katedocument.cpp (Diff revision 1)
bool KateDocument::saveFile()
		2190	backupSuccess = !job->error();

backupSuccess = job->exec(); would be shorter, but yeah, this is equivalent.
I think it's more readable to see immediately that the return value of exec() is checked, rather than looking further down for a check on error() [this applies to the other parts of the patch too].

Thanks for input! I will adjust the places appropriately.

- Michal

On December 21st, 2013, 10:08 p.m. UTC, Michal Humpula wrote:

KIO::NetAccess made it to kde4support, so this is the patch to port from it.

This is my first touch with KIO, so need someone to recheck if it makes sense. Apps are running ok it seems:)