[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kate/frameworks] part: port away from QAbstractItemModel::reset()
From:       Kevin Funk <krf () gmx ! de>
Date:       2013-12-20 10:17:33
Message-ID: 5487489.CyZHB1yc2T () kerberos
[Download RAW message or body]

Am Donnerstag, 19. Dezember 2013, 20:36:44 schrieb Milian Wolff:
> On Thursday 19 December 2013 17:58:25 Michal Humpula wrote:
> > Git commit e6374518f5a966b8badda3a5e90fb873cd7ec08e by Michal Humpula.
> > Committed on 19/12/2013 at 17:54.
> > Pushed by michalhumpula into branch 'frameworks'.
> > 
> > port away from QAbstractItemModel::reset()
> 
> This is potentially dangerous as it can easily lead to undesired
> side-effects, esp. performance wise.
> 
> See also: https://git.reviewboard.kde.org/r/113917/
> 
> Bye

Some hunks of the patch also seem flawed, e.g.:

@@ -1258,7 +1261,9 @@ const QList< QList < int > > & 
KateCompletionModel::columnMerges( ) const
 void KateCompletionModel::setColumnMerges( const QList< QList < int > > & 
columnMerges )
 {
   m_columnMerges = columnMerges;
-  reset();
+
+  beginResetModel();
+  endResetModel();
 }

(the call to beginResetModel() should be the very first statement in this 
block).

Anyway, I'll try to finish up my patch so we can possibly revert 
e6374518f5a966b8badda3a5e90fb873cd7ec08e and re-apply the diff from the 
review-request.

Greets

-- 
Kevin Funk
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]