'Re: Review Request 114551: frameworks: port from KIO::NetAccess'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114551: frameworks: port from KIO::NetAccess
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-12-19 22:54:48
Message-ID: 20131219225448.9374.66552 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114551/
-----------------------------------------------------------

(Updated Dec. 19, 2013, 10:54 p.m.)

Review request for Kate and David Faure.

Changes
-------

Add David for quick review. To me (Dominik) this looks good.

Repository: kate

Description
-------

KIO::NetAccess made it to kde4support, so this is the patch to port from \
it.

This is my first touch with KIO, so need someone to recheck if it makes \
sense. Apps are running ok it seems:)

Diffs
-----

  kate/app/katesession.cpp 17d8741 
  kwrite/kwritemain.cpp fc14fda 
  part/dialogs/katedialogs.cpp c536d3d 
  part/document/katedocument.cpp 286c061 

Diff: http://git.reviewboard.kde.org/r/114551/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114551/">http://git.reviewboard.kde.org/r/114551/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Kate and David Faure.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 19, 2013, 10:54 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add David for quick review. To me (Dominik) this looks \
good.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KIO::NetAccess made it to kde4support, so this is the patch to \
port from it.

This is my first touch with KIO, so need someone to recheck if it makes \
sense. Apps are running ok it seems:)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/katesession.cpp <span style="color: \
grey">(17d8741)</span></li>

 <li>kwrite/kwritemain.cpp <span style="color: grey">(fc14fda)</span></li>

 <li>part/dialogs/katedialogs.cpp <span style="color: \
grey">(c536d3d)</span></li>

 <li>part/document/katedocument.cpp <span style="color: \
grey">(286c061)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114551/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 