[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114224: vi-mode: correctly count the distance to scroll for "zz" command
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2013-12-01 14:11:25
Message-ID: 20131201141125.26028.54630 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 30, 2013, 3:54 p.m., Simon St James wrote:
> > "but... this command is so tied to actual view layer"
> >
> > The visualLineUpDownTests had a similar problem; maybe my approach there could \
> > help. I'm happy for this to just have manual testing, though, since it is so \
> > tricky to test.
> > @Dominik: Could you weigh in on whether this completely solves the bug report or \
> > not?
Yes, the patch is correct: Thinking about it, auto-center lines is of no relevance \
here, since the cursor jumps into the center of the view, which is always ok. Nice \
patch btw. Interesting to see that just 2 lines need to be changed to fix this.
- Dominik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114224/#review44893
-----------------------------------------------------------
On Nov. 30, 2013, 3:54 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114224/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2013, 3:54 p.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 322433
> http://bugs.kde.org/show_bug.cgi?id=322433
>
>
> Repository: kate
>
>
> Description
> -------
>
> This solves the problem 1) and 2) of the bug report. It might very vell solve the \
> 3) too, but I'm not 100% sure, what is the correct way to reproduce that part of \
> the bug. Can anyone try to test it, please?
> I was thinking to come up with some sort of tests, but... this command is so tied \
> to actual view layer, that I've got pretty scared about possibility that test would \
> randomly pass depending on numerous factors like screen resolution (not to mention \
> that it looks like vim tests run in oneline view where "zz" doesn't make sense). On \
> the other hand... there is always the Stub option.
> The names of the variables are pretty stupid, but at least it's more understandable \
> that way.
>
> Diffs
> -----
>
> part/vimode/katevinormalmode.cpp de0b14a
>
> Diff: http://git.reviewboard.kde.org/r/114224/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114224/">http://git.reviewboard.kde.org/r/114224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 30th, 2013, 3:54 p.m. UTC, <b>Simon St \
James</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"but... this command is so tied to actual view layer"
The visualLineUpDownTests had a similar problem; maybe my approach there could help. \
I'm happy for this to just have manual testing, though, since it is so tricky to \
test.
@Dominik: Could you weigh in on whether this completely solves the bug report or \
not?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, the patch is \
correct: Thinking about it, auto-center lines is of no relevance here, since the \
cursor jumps into the center of the view, which is always ok. Nice patch btw. \
Interesting to see that just 2 lines need to be changed to fix this.</pre> <br />
<p>- Dominik</p>
<br />
<p>On November 30th, 2013, 3:54 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2013, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=322433">322433</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This solves the problem 1) and 2) of the bug report. It might very vell \
solve the 3) too, but I'm not 100% sure, what is the correct way to reproduce \
that part of the bug. Can anyone try to test it, please?
I was thinking to come up with some sort of tests, but... this command is so tied to \
actual view layer, that I've got pretty scared about possibility that test would \
randomly pass depending on numerous factors like screen resolution (not to mention \
that it looks like vim tests run in oneline view where "zz" doesn't \
make sense). On the other hand... there is always the Stub option.
The names of the variables are pretty stupid, but at least it's more \
understandable that way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(de0b14a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114224/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic