'Re: Review Request 114224: vi-mode: correctly count the distance to scroll for "zz" command'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114224: vi-mode: correctly count the distance to scroll for "zz" command
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-11-30 15:54:47
Message-ID: 20131130155447.20272.40408 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114224/
-----------------------------------------------------------

(Updated Nov. 30, 2013, 3:54 p.m.)

Review request for Kate.

Changes
-------

restyled patch

Bugs: 322433
    http://bugs.kde.org/show_bug.cgi?id=322433

Repository: kate

Description
-------

This solves the problem 1) and 2) of the bug report. It might very vell solve the 3) \
too, but I'm not 100% sure, what is the correct way to reproduce that part of the \
bug. Can anyone try to test it, please?

I was thinking to come up with some sort of tests, but... this command is so tied to \
actual view layer, that I've got pretty scared about possibility that test would \
randomly pass depending on numerous factors like screen resolution (not to mention \
that it looks like vim tests run in oneline view where "zz" doesn't make sense). On \
the other hand... there is always the Stub option.

The names of the variables are pretty stupid, but at least it's more understandable \
that way.

Diffs (updated)
-----

  part/vimode/katevinormalmode.cpp de0b14a 

Diff: http://git.reviewboard.kde.org/r/114224/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114224/">http://git.reviewboard.kde.org/r/114224/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Nov. 30, 2013, 3:54 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">restyled patch</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=322433">322433</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This solves the problem 1) and 2) of the bug report. It might very vell \
solve the 3) too, but I&#39;m not 100% sure, what is the correct way to reproduce \
that part of the bug. Can anyone try to test it, please?

I was thinking to come up with some sort of tests, but... this command is so tied to \
actual view layer, that I&#39;ve got pretty scared about possibility that test would \
randomly pass depending on numerous factors like screen resolution (not to mention \
that it looks like vim tests run in oneline view where &quot;zz&quot; doesn&#39;t \
make sense). On the other hand... there is always the Stub option.

The names of the variables are pretty stupid, but at least it&#39;s more \
understandable that way.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevinormalmode.cpp <span style="color: grey">(de0b14a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114224/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 