'Re: Review Request 114073: make indent work properly when invoked from cmdline in vi-mode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114073: make indent work properly when invoked from cmdline in vi-mode
From:       "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date:       2013-11-25 15:48:53
Message-ID: 20131125154853.17604.33448 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114073/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 3:48 p.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: kate

Description
-------

This patch has few "nasties" in it:

1) repairs behaviour only for ">" and "<" commands (not "y", "d", ...). If we can \
agree on that this is the correct way to do, I can broaden the change in patch. 2) \
creates new hooks in KateViNormalMode. 3) under de hood, provides translation from \
Vim conception of selection to Kate one.

suggestions on how to improve greatly welcomed.

The reason for change is similar to https://git.reviewboard.kde.org/r/114061/.

Diffs
-----

  part/vimode/katevinormalmode.cpp 27654a5 
  tests/vimode_test.cpp 7895dd5 

Diff: http://git.reviewboard.kde.org/r/114073/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114073/">http://git.reviewboard.kde.org/r/114073/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Nov. 25, 2013, 3:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch has few &quot;nasties&quot; in it:

1) repairs behaviour only for &quot;&gt;&quot; and &quot;&lt;&quot; commands (not \
&quot;y&quot;, &quot;d&quot;, ...). If we can agree on that this is the correct way \
to do, I can broaden the change in patch. 2) creates new hooks in KateViNormalMode.
3) under de hood, provides translation from Vim conception of selection to Kate one.

suggestions on how to improve greatly welcomed.

The reason for change is similar to https://git.reviewboard.kde.org/r/114061/.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevinormalmode.cpp <span style="color: grey">(27654a5)</span></li>

 <li>tests/vimode_test.cpp <span style="color: grey">(7895dd5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114073/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 