From kwrite-devel Mon Nov 25 15:48:53 2013 From: "Michal Humpula" Date: Mon, 25 Nov 2013 15:48:53 +0000 To: kwrite-devel Subject: Re: Review Request 114073: make indent work properly when invoked from cmdline in vi-mode Message-Id: <20131125154853.17604.33448 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138539454515763 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2885117236973584845==" --===============2885117236973584845== Content-Type: multipart/alternative; boundary="===============2284336900635759975==" --===============2284336900635759975== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114073/ ----------------------------------------------------------- (Updated Nov. 25, 2013, 3:48 p.m.) Status ------ This change has been discarded. Review request for Kate. Repository: kate Description ------- This patch has few "nasties" in it: 1) repairs behaviour only for ">" and "<" commands (not "y", "d", ...). If we can agree on that this is the correct way to do, I can broaden the change in patch. 2) creates new hooks in KateViNormalMode. 3) under de hood, provides translation from Vim conception of selection to Kate one. suggestions on how to improve greatly welcomed. The reason for change is similar to https://git.reviewboard.kde.org/r/114061/. Diffs ----- part/vimode/katevinormalmode.cpp 27654a5 tests/vimode_test.cpp 7895dd5 Diff: http://git.reviewboard.kde.org/r/114073/diff/ Testing ------- Thanks, Michal Humpula --===============2284336900635759975== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114073/

This change has been discarded.

Review request for Kate.

By Michal Humpula.

Updated Nov. 25, 2013, 3:48 p.m.

Repository: kate

Description

This patch has few "nasties" in it:

1) repairs behaviour only for ">" and "<" commands (not "y", "d", ...). If we can agree on that this is the correct way to do, I can broaden the change in patch.
2) creates new hooks in KateViNormalMode.
3) under de hood, provides translation from Vim conception of selection to Kate one.

suggestions on how to improve greatly welcomed.

The reason for change is similar to https://git.reviewboard.kde.org/r/114061/.

Diffs

part/vimode/katevinormalmode.cpp (27654a5)
tests/vimode_test.cpp (7895dd5)

View Diff

--===============2284336900635759975==-- --===============2885117236973584845== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============2885117236973584845==--