[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113790: added jshint and restructured jsutils
From: Pablo_Martín <goinnn () gmail ! com>
Date: 2013-11-11 13:21:32
Message-ID: 20131111132132.20369.68663 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 11, 2013, 1:14 p.m., Pablo Martín wrote:
> > Please could you tell me if is there some settings to desactive the jslint when \
> > save?
> > Something like in the old version?
> >
> > https://projects.kde.org/projects/kde/applications/kate/repository/revisions/master/entry/addons/kate/pate/src/plugins/js_utils/jslint.py#L49
> >
Please could you tell me if is there some settings to deactivate the jslint when save \
a file?
- Pablo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113790/#review43427
-----------------------------------------------------------
On Nov. 11, 2013, 12:38 p.m., Phil Schaf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113790/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 12:38 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> restructured JSUtils and added an option to use JSHint instead of the opinionated \
> JSLint.
> removed dependency (we don't need a clumsy JS wrapper using system calls if Qt \
> already has a JS runtime)
> removed necessity ro restart kate after changing settings.
>
> i created many useful utilities in the process which simplify settings and JS. \
> maybe we could add them to libkatepate?
>
> Diffs
> -----
>
> addons/kate/pate/src/CMakeLists.txt 78bbdc0
> addons/kate/pate/src/plugins/js_utils/fulljslint.js PRE-CREATION
> addons/kate/pate/src/plugins/js_utils/js_autocomplete.py 40b1523
> addons/kate/pate/src/plugins/js_utils/js_engine.py PRE-CREATION
> addons/kate/pate/src/plugins/js_utils/js_lint.py PRE-CREATION
> addons/kate/pate/src/plugins/js_utils/js_settings.py 4272372
> addons/kate/pate/src/plugins/js_utils/js_snippets.py d684b25
> addons/kate/pate/src/plugins/js_utils/js_utils.py ee879a0
> addons/kate/pate/src/plugins/js_utils/js_utils.ui 6fd8b20
> addons/kate/pate/src/plugins/js_utils/jshint.js PRE-CREATION
> addons/kate/pate/src/plugins/js_utils/jslint.py 03fea05
> addons/kate/pate/src/plugins/js_utils/json_pretty.py 135e72d
>
> Diff: http://git.reviewboard.kde.org/r/113790/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Phil Schaf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113790/">http://git.reviewboard.kde.org/r/113790/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 11th, 2013, 1:14 p.m. UTC, <b>Pablo \
Martín</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Please could you tell me if is there some settings to desactive the \
jslint when save?
Something like in the old version?
https://projects.kde.org/projects/kde/applications/kate/repository/revisions/master/entry/addons/kate/pate/src/plugins/js_utils/jslint.py#L49</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please could you tell me \
if is there some settings to deactivate the jslint when save a file? </pre>
<br />
<p>- Pablo</p>
<br />
<p>On November 11th, 2013, 12:38 p.m. UTC, Phil Schaf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Phil Schaf.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2013, 12:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">restructured JSUtils and added an option to use JSHint instead of the \
opinionated JSLint.
removed dependency (we don't need a clumsy JS wrapper using system calls if Qt \
already has a JS runtime)
removed necessity ro restart kate after changing settings.
i created many useful utilities in the process which simplify settings and JS. maybe \
we could add them to libkatepate?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/pate/src/CMakeLists.txt <span style="color: \
grey">(78bbdc0)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/fulljslint.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_autocomplete.py <span style="color: \
grey">(40b1523)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_engine.py <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_lint.py <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_settings.py <span style="color: \
grey">(4272372)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_snippets.py <span style="color: \
grey">(d684b25)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_utils.py <span style="color: \
grey">(ee879a0)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/js_utils.ui <span style="color: \
grey">(6fd8b20)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/jshint.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/jslint.py <span style="color: \
grey">(03fea05)</span></li>
<li>addons/kate/pate/src/plugins/js_utils/json_pretty.py <span style="color: \
grey">(135e72d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113790/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic