This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113790/

On November 11th, 2013, 1:14 p.m. UTC, Pablo Martín wrote:

Please could you tell me if is there some settings to desactive the jslint when save?

Something like in the old version?

https://projects.kde.org/projects/kde/applications/kate/repository/revisions/master/entry/addons/kate/pate/src/plugins/js_utils/jslint.py#L49
Please could you tell me if is there some settings to deactivate the jslint when save a file?

- Pablo


On November 11th, 2013, 12:38 p.m. UTC, Phil Schaf wrote:

Review request for Kate.
By Phil Schaf.

Updated Nov. 11, 2013, 12:38 p.m.

Repository: kate

Description

restructured JSUtils and added an option to use JSHint instead of the opinionated JSLint.

removed dependency (we don’t need a clumsy JS wrapper using system calls if Qt already has a JS runtime)

removed necessity ro restart kate after changing settings.

i created many useful utilities in the process which simplify settings and JS. maybe we could add them to libkatepate?

Diffs

  • addons/kate/pate/src/CMakeLists.txt (78bbdc0)
  • addons/kate/pate/src/plugins/js_utils/fulljslint.js (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/js_autocomplete.py (40b1523)
  • addons/kate/pate/src/plugins/js_utils/js_engine.py (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/js_lint.py (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/js_settings.py (4272372)
  • addons/kate/pate/src/plugins/js_utils/js_snippets.py (d684b25)
  • addons/kate/pate/src/plugins/js_utils/js_utils.py (ee879a0)
  • addons/kate/pate/src/plugins/js_utils/js_utils.ui (6fd8b20)
  • addons/kate/pate/src/plugins/js_utils/jshint.js (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/jslint.py (03fea05)
  • addons/kate/pate/src/plugins/js_utils/json_pretty.py (135e72d)

View Diff