[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 109326: added jedi-autocompletion
From: "Phil Schaf" <flying-sheep () web ! de>
Date: 2013-05-02 15:11:05
Message-ID: 20130502151105.20844.86353 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 30, 2013, 7:33 a.m., Dominik Haumann wrote:
> > @other reviewers: 2 weeks no feedback. Can you please have a look? Otherwise, \
> > I'll give a ship it ;)
unfortunately Pablo thought it would be a good idea to introduce *some* of the \
changes which i made during this review request himself, in a slightly different way, \
while changing other bits.
so this diff is unusable.
it would be really nice if Pablo would fix that so that i don't have to, as he could \
simply have waited for this to land instead of picking some parts and committing \
them.
- Phil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109326/#review31800
-----------------------------------------------------------
On April 11, 2013, 12:40 p.m., Phil Schaf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109326/
> -----------------------------------------------------------
>
> (Updated April 11, 2013, 12:40 p.m.)
>
>
> Review request for Kate.
>
>
> Description
> -------
>
> works really nice for a start :)
>
> one thing i pulled from python_utils and don't 100% understand, however: what does \
> self.createIndex(row, col, 1) do? why the magic 1?
> another thing: is there an event i can use like "mimeTypeChanged"? i'd like not to \
> have the model loaded on views that don't contain a python buffer. even if \
> completionInvoked exits early in that case, it still burns a few useless cycles.
>
> Diffs
> -----
>
> kate/plugins/pate/src/plugins/libkatepate/autocomplete.py \
> e1d767490d2fc40fe787f742ffc180a131675471 \
> kate/plugins/pate/src/plugins/libkatepate/debug.py PRE-CREATION \
> kate/plugins/pate/src/plugins/python_autocomplete_jedi.py PRE-CREATION
> Diff: http://git.reviewboard.kde.org/r/109326/diff/
>
>
> Testing
> -------
>
> caveats:
>
> 1. seems not to work in any case: sometimes it doesn't get that you're in a \
> function 2. the one initial completion is slow, after that it seems to have it \
> cached/loaded and is fast
> nothing that makes it useless or unusable :)
>
>
> Thanks,
>
> Phil Schaf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109326/">http://git.reviewboard.kde.org/r/109326/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 30th, 2013, 7:33 a.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">@other reviewers: 2 weeks no feedback. Can you please have a look? \
Otherwise, I'll give a ship it ;)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unfortunately Pablo \
thought it would be a good idea to introduce *some* of the changes which i made \
during this review request himself, in a slightly different way, while changing other \
bits.
so this diff is unusable.
it would be really nice if Pablo would fix that so that i don't have to, as he could \
simply have waited for this to land instead of picking some parts and committing \
them.</pre> <br />
<p>- Phil</p>
<br />
<p>On April 11th, 2013, 12:40 p.m. UTC, Phil Schaf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Phil Schaf.</div>
<p style="color: grey;"><i>Updated April 11, 2013, 12:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works really nice for a start :)
one thing i pulled from python_utils and don't 100% understand, however: what does \
self.createIndex(row, col, 1) do? why the magic 1?
another thing: is there an event i can use like "mimeTypeChanged"? i'd like not to \
have the model loaded on views that don't contain a python buffer. even if \
completionInvoked exits early in that case, it still burns a few useless \
cycles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">caveats:
1. seems not to work in any case: sometimes it doesn't get that you're in a function
2. the one initial completion is slow, after that it seems to have it cached/loaded \
and is fast
nothing that makes it useless or unusable :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/plugins/pate/src/plugins/libkatepate/autocomplete.py <span style="color: \
grey">(e1d767490d2fc40fe787f742ffc180a131675471)</span></li>
<li>kate/plugins/pate/src/plugins/libkatepate/debug.py <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/plugins/pate/src/plugins/python_autocomplete_jedi.py <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109326/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic