'Re: Review Request 110219: mode variable for adjusting indentation of code pasted from the clipboard'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 110219: mode variable for adjusting indentation of code pasted from the clipboard
From:       "Gerald Senarclens de Grancy" <oss () senarclens ! eu>
Date:       2013-04-27 16:32:15
Message-ID: 20130427163215.6412.58920 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110219/
-----------------------------------------------------------

(Updated April 27, 2013, 4:32 p.m.)

Review request for Kate and Dominik Haumann.

Changes
-------

forgot to add the new variable to configuring.docbook

Description
-------

Added a mode variable to disable/ enable adjusting indentation for code pasted from \
the clipboard. Used it in the global modeline for Python. This is required for Python \
b/c adjusting the indentation is dangerous and can lead to bugs.

Diffs (updated)
-----

  doc/kate/configuring.docbook a768cfe 
  part/data/katemoderc 7ac52ae 
  part/document/katedocument.cpp 37e6635 
  part/utils/katecmds.cpp 5a81437 
  part/variableeditor/variablelineedit.cpp 44f14b6 

Diff: http://git.reviewboard.kde.org/r/110219/diff/

Testing
-------

worked fine in manual testing

Thanks,

Gerald Senarclens de Grancy

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110219/">http://git.reviewboard.kde.org/r/110219/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Dominik Haumann.</div>
<div>By Gerald Senarclens de Grancy.</div>

<p style="color: grey;"><i>Updated April 27, 2013, 4:32 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">forgot to add the new variable to configuring.docbook</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added a mode variable to disable/ enable adjusting indentation for code \
pasted from the clipboard. Used it in the global modeline for Python. This is \
required for Python b/c adjusting the indentation is dangerous and can lead to \
bugs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">worked fine in manual testing</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>doc/kate/configuring.docbook <span style="color: grey">(a768cfe)</span></li>

 <li>part/data/katemoderc <span style="color: grey">(7ac52ae)</span></li>

 <li>part/document/katedocument.cpp <span style="color: grey">(37e6635)</span></li>

 <li>part/utils/katecmds.cpp <span style="color: grey">(5a81437)</span></li>

 <li>part/variableeditor/variablelineedit.cpp <span style="color: \
grey">(44f14b6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110219/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 