[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 110018: Rewrote xml indentation script and added some tests
From: "Commit Hook" <null () kde ! org>
Date: 2013-04-15 23:54:18
Message-ID: 20130415235418.2960.13750 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110018/
-----------------------------------------------------------
(Updated April 15, 2013, 11:54 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate.
Description
-------
After spending too much time trying to improve the original regular expression based \
xml.js, I re-did it using the lovely isCode, isComment, is... functions.
Works pretty good, but it's hard to compare with what was done w/ the old xml.js as \
there were no tests.
A remaining issue is that this rewrite is also affected by Bug 316809.
Diffs
-----
part/script/data/indentation/xml.js ff92f18
part/script/data/libraries/string.js 406ac4f
tests/data/indent/xml/.kateconfig PRE-CREATION
tests/data/indent/xml/arguments1/expected PRE-CREATION
tests/data/indent/xml/arguments1/input.js PRE-CREATION
tests/data/indent/xml/arguments1/origin PRE-CREATION
tests/data/indent/xml/arguments2/expected PRE-CREATION
tests/data/indent/xml/arguments2/input.js PRE-CREATION
tests/data/indent/xml/arguments2/origin PRE-CREATION
tests/data/indent/xml/arguments3/expected PRE-CREATION
tests/data/indent/xml/arguments3/input.js PRE-CREATION
tests/data/indent/xml/arguments3/origin PRE-CREATION
tests/data/indent/xml/arguments4/expected PRE-CREATION
tests/data/indent/xml/arguments4/input.js PRE-CREATION
tests/data/indent/xml/arguments4/origin PRE-CREATION
tests/data/indent/xml/closing1/expected PRE-CREATION
tests/data/indent/xml/closing1/input.js PRE-CREATION
tests/data/indent/xml/closing1/origin PRE-CREATION
tests/data/indent/xml/closing2/expected PRE-CREATION
tests/data/indent/xml/closing2/input.js PRE-CREATION
tests/data/indent/xml/closing2/origin PRE-CREATION
tests/data/indent/xml/closing3/expected PRE-CREATION
tests/data/indent/xml/closing3/input.js PRE-CREATION
tests/data/indent/xml/closing3/origin PRE-CREATION
tests/data/indent/xml/comment1/README PRE-CREATION
tests/data/indent/xml/comment1/expected PRE-CREATION
tests/data/indent/xml/comment1/input.js PRE-CREATION
tests/data/indent/xml/comment1/origin PRE-CREATION
tests/data/indent/xml/comment2/expected PRE-CREATION
tests/data/indent/xml/comment2/input.js PRE-CREATION
tests/data/indent/xml/comment2/origin PRE-CREATION
tests/data/indent/xml/opening1/expected PRE-CREATION
tests/data/indent/xml/opening1/input.js PRE-CREATION
tests/data/indent/xml/opening1/origin PRE-CREATION
tests/data/indent/xml/self_closing1/expected PRE-CREATION
tests/data/indent/xml/self_closing1/input.js PRE-CREATION
tests/data/indent/xml/self_closing1/origin PRE-CREATION
tests/data/indent/xml/text1/expected PRE-CREATION
tests/data/indent/xml/text1/input.js PRE-CREATION
tests/data/indent/xml/text1/origin PRE-CREATION
tests/data/indent/xml/text2/expected PRE-CREATION
tests/data/indent/xml/text2/input.js PRE-CREATION
tests/data/indent/xml/text2/origin PRE-CREATION
tests/data/indent/xml/xhtml1/expected PRE-CREATION
tests/data/indent/xml/xhtml1/input.js PRE-CREATION
tests/data/indent/xml/xhtml1/origin PRE-CREATION
tests/indenttest.h e9e1609
tests/indenttest.cpp c3ffbed
Diff: http://git.reviewboard.kde.org/r/110018/diff/
Testing
-------
Wrote a series of blackbox tests and they all pass.
Thanks,
Gerald Senarclens de Grancy
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110018/">http://git.reviewboard.kde.org/r/110018/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Gerald Senarclens de Grancy.</div>
<p style="color: grey;"><i>Updated April 15, 2013, 11:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After spending too much time trying to improve the original regular \
expression based xml.js, I re-did it using the lovely isCode, isComment, is... \
functions.
Works pretty good, but it's hard to compare with what was done w/ the old xml.js \
as there were no tests.
A remaining issue is that this rewrite is also affected by Bug 316809.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Wrote a series of blackbox tests and they all pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/script/data/indentation/xml.js <span style="color: \
grey">(ff92f18)</span></li>
<li>part/script/data/libraries/string.js <span style="color: \
grey">(406ac4f)</span></li>
<li>tests/data/indent/xml/.kateconfig <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments2/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments2/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments2/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments3/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments3/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments3/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments4/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments4/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/arguments4/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing2/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing2/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing2/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing3/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing3/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/closing3/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment1/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment2/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment2/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/comment2/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/opening1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/opening1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/opening1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/self_closing1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/self_closing1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/self_closing1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/text1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/text1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/text1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/text2/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/text2/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/text2/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/xhtml1/expected <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/xhtml1/input.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/data/indent/xml/xhtml1/origin <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/indenttest.h <span style="color: grey">(e9e1609)</span></li>
<li>tests/indenttest.cpp <span style="color: grey">(c3ffbed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110018/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic