This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110018/

This change has been marked as submitted.

Review request for Kate.
By Gerald Senarclens de Grancy.

Updated April 15, 2013, 11:54 p.m.

Description 

After spending too much time trying to improve the original regular expression based xml.js, I re-did it using the lovely isCode, isComment, is... functions.

Works pretty good, but it's hard to compare with what was done w/ the old xml.js as there were no tests.

A remaining issue is that this rewrite is also affected by Bug 316809.

Testing 

Wrote a series of blackbox tests and they all pass.

Diffs

  • part/script/data/indentation/xml.js (ff92f18)
  • part/script/data/libraries/string.js (406ac4f)
  • tests/data/indent/xml/.kateconfig (PRE-CREATION)
  • tests/data/indent/xml/arguments1/expected (PRE-CREATION)
  • tests/data/indent/xml/arguments1/input.js (PRE-CREATION)
  • tests/data/indent/xml/arguments1/origin (PRE-CREATION)
  • tests/data/indent/xml/arguments2/expected (PRE-CREATION)
  • tests/data/indent/xml/arguments2/input.js (PRE-CREATION)
  • tests/data/indent/xml/arguments2/origin (PRE-CREATION)
  • tests/data/indent/xml/arguments3/expected (PRE-CREATION)
  • tests/data/indent/xml/arguments3/input.js (PRE-CREATION)
  • tests/data/indent/xml/arguments3/origin (PRE-CREATION)
  • tests/data/indent/xml/arguments4/expected (PRE-CREATION)
  • tests/data/indent/xml/arguments4/input.js (PRE-CREATION)
  • tests/data/indent/xml/arguments4/origin (PRE-CREATION)
  • tests/data/indent/xml/closing1/expected (PRE-CREATION)
  • tests/data/indent/xml/closing1/input.js (PRE-CREATION)
  • tests/data/indent/xml/closing1/origin (PRE-CREATION)
  • tests/data/indent/xml/closing2/expected (PRE-CREATION)
  • tests/data/indent/xml/closing2/input.js (PRE-CREATION)
  • tests/data/indent/xml/closing2/origin (PRE-CREATION)
  • tests/data/indent/xml/closing3/expected (PRE-CREATION)
  • tests/data/indent/xml/closing3/input.js (PRE-CREATION)
  • tests/data/indent/xml/closing3/origin (PRE-CREATION)
  • tests/data/indent/xml/comment1/README (PRE-CREATION)
  • tests/data/indent/xml/comment1/expected (PRE-CREATION)
  • tests/data/indent/xml/comment1/input.js (PRE-CREATION)
  • tests/data/indent/xml/comment1/origin (PRE-CREATION)
  • tests/data/indent/xml/comment2/expected (PRE-CREATION)
  • tests/data/indent/xml/comment2/input.js (PRE-CREATION)
  • tests/data/indent/xml/comment2/origin (PRE-CREATION)
  • tests/data/indent/xml/opening1/expected (PRE-CREATION)
  • tests/data/indent/xml/opening1/input.js (PRE-CREATION)
  • tests/data/indent/xml/opening1/origin (PRE-CREATION)
  • tests/data/indent/xml/self_closing1/expected (PRE-CREATION)
  • tests/data/indent/xml/self_closing1/input.js (PRE-CREATION)
  • tests/data/indent/xml/self_closing1/origin (PRE-CREATION)
  • tests/data/indent/xml/text1/expected (PRE-CREATION)
  • tests/data/indent/xml/text1/input.js (PRE-CREATION)
  • tests/data/indent/xml/text1/origin (PRE-CREATION)
  • tests/data/indent/xml/text2/expected (PRE-CREATION)
  • tests/data/indent/xml/text2/input.js (PRE-CREATION)
  • tests/data/indent/xml/text2/origin (PRE-CREATION)
  • tests/data/indent/xml/xhtml1/expected (PRE-CREATION)
  • tests/data/indent/xml/xhtml1/input.js (PRE-CREATION)
  • tests/data/indent/xml/xhtml1/origin (PRE-CREATION)
  • tests/indenttest.h (e9e1609)
  • tests/indenttest.cpp (c3ffbed)

View Diff