[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request: Tidy up Python 3 support.
From: "Shaheed Haque" <srhaque () theiet ! org>
Date: 2012-11-24 0:54:32
Message-ID: 20121124005432.27210.27385 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107391/#review22450
-----------------------------------------------------------
I think I understand the link problem I am seeing. In summary:
1. Ubuntu 12.10 supports Python 2.7 and 3.2. There is no option for 3.3 at =
this time.
2. The cmake support available does not correctly detect Python3. I get thi=
s:
-- Found PythonInterp: /usr/bin/python3 (found version "3.2.3") =
-- Found Python executable: /usr/bin/python3
-- Found Python version: 3.2.3
-- Found Python library: PYTHON_LIBRARY-NOTFOUND
3. That appears to be due to the issues fixed here in Patch 2/2:
http://public.kitware.com/pipermail/cmake-developers/2012-March/003747.html
FWIW, Patch 1/2 in that series is why my switching between 2.7 and 3.2 did =
not work resulting in compiling against 3.2, but trying to link against 2.7=
(hence the errors I hit). In other words, it is clear that the support for=
Python 3.anything is relatively immature, and, realistically, from-git sup=
port for it will have to wait till several pieces of upstream make it down =
to users like me.
Further, I suspect that by the time those fixes arrive, 3.3 will be mainstr=
eam.
Now, I believe the code is very close to correct for 3.2 and 3.3, though th=
e AS_DATA usage for 3.3 will eventully have to be replaced. So, unless ther=
e are objections, I plan to commit the code as-is, and offer support on an =
ad-hoc basis to any brave souls who want to try to get 3.x support going.
- Shaheed Haque
On Nov. 22, 2012, 7:07 p.m., Shaheed Haque wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107391/
> -----------------------------------------------------------
> =
> (Updated Nov. 22, 2012, 7:07 p.m.)
> =
> =
> Review request for Kate and Luca Beltrame.
> =
> =
> Description
> -------
> =
> Tidy up Python 3 support by rationalising the #ifs contributed by Luca vi=
a https://git.reviewboard.kde.org/r/107362/
> =
> =
> Diffs
> -----
> =
> kate/plugins/pate/src/engine.cpp 487a8574ffb60eb2e846faa79cc9de529f3921=
9c =
> kate/plugins/pate/src/plugin.cpp a1dfa4843a3efa3689d1543fc72bafe46ac134=
6a =
> kate/plugins/pate/src/utilities.h 7edf71c83523354cfd5b9bda4a6d7de6e9e1c=
41d =
> kate/plugins/pate/src/utilities.cpp 20e53a3abff47d99fdf37f435a963f4d714=
f8ac5 =
> =
> Diff: http://git.reviewboard.kde.org/r/107391/diff/
> =
> =
> Testing
> -------
> =
> Compiled/tested with Python 2.
> =
> =
> Thanks,
> =
> Shaheed Haque
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107391/">http://git.reviewboard.kde.org/r/107391/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think I understand the \
link problem I am seeing. In summary:
1. Ubuntu 12.10 supports Python 2.7 and 3.2. There is no option for 3.3 at this time.
2. The cmake support available does not correctly detect Python3. I get this:
-- Found PythonInterp: /usr/bin/python3 (found version "3.2.3")
-- Found Python executable: /usr/bin/python3
-- Found Python version: 3.2.3
-- Found Python library: PYTHON_LIBRARY-NOTFOUND
3. That appears to be due to the issues fixed here in Patch 2/2:
http://public.kitware.com/pipermail/cmake-developers/2012-March/003747.html
FWIW, Patch 1/2 in that series is why my switching between 2.7 and 3.2 did not work \
resulting in compiling against 3.2, but trying to link against 2.7 (hence the errors \
I hit). In other words, it is clear that the support for Python 3.anything is \
relatively immature, and, realistically, from-git support for it will have to wait \
till several pieces of upstream make it down to users like me.
Further, I suspect that by the time those fixes arrive, 3.3 will be mainstream.
Now, I believe the code is very close to correct for 3.2 and 3.3, though the AS_DATA \
usage for 3.3 will eventully have to be replaced. So, unless there are objections, I \
plan to commit the code as-is, and offer support on an ad-hoc basis to any brave \
souls who want to try to get 3.x support going.</pre> <br />
<p>- Shaheed</p>
<br />
<p>On November 22nd, 2012, 7:07 p.m., Shaheed Haque wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Luca Beltrame.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 7:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tidy up Python 3 support by rationalising the #ifs contributed by Luca \
via https://git.reviewboard.kde.org/r/107362/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled/tested with Python 2.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/plugins/pate/src/engine.cpp <span style="color: \
grey">(487a8574ffb60eb2e846faa79cc9de529f39219c)</span></li>
<li>kate/plugins/pate/src/plugin.cpp <span style="color: \
grey">(a1dfa4843a3efa3689d1543fc72bafe46ac1346a)</span></li>
<li>kate/plugins/pate/src/utilities.h <span style="color: \
grey">(7edf71c83523354cfd5b9bda4a6d7de6e9e1c41d)</span></li>
<li>kate/plugins/pate/src/utilities.cpp <span style="color: \
grey">(20e53a3abff47d99fdf37f435a963f4d714f8ac5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107391/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic