[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request: Plugin for collobarative text editing
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2012-06-30 13:41:37
Message-ID: 20120630134137.21246.51928 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 17, 2012, 10:35 a.m., Dominik Haumann wrote:
> > Given it's simplistic design and minimal code length, it's quite surpri=
sing that it works as you write. A description btw. can be found on http://=
habrahabr.ru/post/145663/ (translate this page to english with a browser).
> > =
> > Still, what happens if two people write at the same cursor position? As=
I understand, it is possible that the clients get out of sync, right?
> =
> Filipp Kovalev wrote:
> Such possibility is very very low. But we can fix it if required. We =
tested it with different numbers of clients - everything looks fine. You ar=
e right - it's rather minimalistic, but we convinced that overfunctionality=
is evil.
> P. S. It's our article on habr.
I've tried the plugin.
Sometimes it crashes when clicking apply in the client. Further, in Tools t=
he action item's name is "connect_to_server". A "create server" action does=
not exist. Further, if a server is already open, it's unclear what happens=
if you open another file and then want to open a server there. Wouldn't it=
be better to have kind of a GUI/dialog that lists clients and so on?
As a prototype, this certainly is an interesting approach. But it would nee=
d more in order to make it a solid plugin that is usable for all users and,=
at the same time, makes sure the documents are always syncronized.
It would be nice, if you continue here and provide another patch? :)
- Dominik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105231/#review14806
-----------------------------------------------------------
On June 12, 2012, 6:22 p.m., Dmitrii Kosarev wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105231/
> -----------------------------------------------------------
> =
> (Updated June 12, 2012, 6:22 p.m.)
> =
> =
> Review request for Kate.
> =
> =
> Description
> -------
> =
> Plugin can be a server or a client. Many clients can connect to one serve=
r. Undo is supported.
> =
> =
> Diffs
> -----
> =
> part/plugins/CMakeLists.txt c14d6c7 =
> part/plugins/neznaju/.gitignore PRE-CREATION =
> part/plugins/neznaju/CMakeLists.txt PRE-CREATION =
> part/plugins/neznaju/README.md PRE-CREATION =
> part/plugins/neznaju/ktexteditor_neznaju.desktop PRE-CREATION =
> part/plugins/neznaju/neznaju.h PRE-CREATION =
> part/plugins/neznaju/neznaju.cpp PRE-CREATION =
> part/plugins/neznaju/neznajuPlugin.h PRE-CREATION =
> part/plugins/neznaju/neznajuPlugin.cpp PRE-CREATION =
> part/plugins/neznaju/neznajuui.rc PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/105231/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dmitrii Kosarev
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105231/">http://git.reviewboard.kde.org/r/105231/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 17th, 2012, 10:35 a.m., <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Given it's simplistic design and minimal code length, it's quite \
surprising that it works as you write. A description btw. can be found on \
http://habrahabr.ru/post/145663/ (translate this page to english with a browser).
Still, what happens if two people write at the same cursor position? As I understand, \
it is possible that the clients get out of sync, right?</pre> </blockquote>
<p>On June 17th, 2012, 2:12 p.m., <b>Filipp Kovalev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Such possibility is very \
very low. But we can fix it if required. We tested it with different numbers of \
clients - everything looks fine. You are right - it's rather minimalistic, but we \
convinced that overfunctionality is evil. P. S. It's our article on habr.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tried the \
plugin. Sometimes it crashes when clicking apply in the client. Further, in Tools the \
action item's name is "connect_to_server". A "create server" \
action does not exist. Further, if a server is already open, it's unclear what \
happens if you open another file and then want to open a server there. Wouldn't \
it be better to have kind of a GUI/dialog that lists clients and so on?
As a prototype, this certainly is an interesting approach. But it would need more in \
order to make it a solid plugin that is usable for all users and, at the same time, \
makes sure the documents are always syncronized.
It would be nice, if you continue here and provide another patch? :)</pre>
<br />
<p>- Dominik</p>
<br />
<p>On June 12th, 2012, 6:22 p.m., Dmitrii Kosarev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Dmitrii Kosarev.</div>
<p style="color: grey;"><i>Updated June 12, 2012, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plugin can be a server or a client. Many clients can connect to one \
server. Undo is supported.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/plugins/CMakeLists.txt <span style="color: grey">(c14d6c7)</span></li>
<li>part/plugins/neznaju/.gitignore <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/README.md <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/ktexteditor_neznaju.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/neznaju.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/neznaju.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/neznajuPlugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/neznajuPlugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/plugins/neznaju/neznajuui.rc <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105231/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic