[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request: Bug 290064
From: "Erlend Hamberg" <ehamberg () gmail ! com>
Date: 2012-06-28 18:47:11
Message-ID: 20120628184711.4372.47524 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104644/#review15243
-----------------------------------------------------------
Ship it!
This was applied as 5ccaab4782b5ae520b332e0a0dc145a593f52e3b 17 April.
- Erlend Hamberg
On April 17, 2012, 3:44 p.m., Svyatoslav Kuzmich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104644/
> -----------------------------------------------------------
>
> (Updated April 17, 2012, 3:44 p.m.)
>
>
> Review request for Kate and Erlend Hamberg.
>
>
> Description
> -------
>
> Bug 290064 - "Kate (part) vi mode :sort function uses only kate selection, not vi \
> visual selection" fixed
> Problem: Some Kate commands (like :sort) use selection for range but Vi Mode clears \
> selection after exiting Visual Mode.
> Solution:
> 1. Keeping selection turned on after entering Command line mode.
> 2. Clearing selection after exiting Command line mode. (Only for Vi Mode)
>
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=290064.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290064
>
>
> Diffs
> -----
>
> part/view/kateviewhelpers.cpp f71f934
> part/vimode/kateviinputmodemanager.h f02a709
> part/vimode/kateviinputmodemanager.cpp 4776380
> part/vimode/katevinormalmode.h 6d2a7c8
> part/vimode/katevinormalmode.cpp 5a59cc2
> part/vimode/katevivisualmode.h e7b417a
> part/vimode/katevivisualmode.cpp 67ef9c6
>
> Diff: http://git.reviewboard.kde.org/r/104644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Svyatoslav Kuzmich
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104644/">http://git.reviewboard.kde.org/r/104644/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was applied as \
5ccaab4782b5ae520b332e0a0dc145a593f52e3b 17 April.</pre> <br />
<p>- Erlend</p>
<br />
<p>On April 17th, 2012, 3:44 p.m., Svyatoslav Kuzmich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Erlend Hamberg.</div>
<div>By Svyatoslav Kuzmich.</div>
<p style="color: grey;"><i>Updated April 17, 2012, 3:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Bug 290064 - "Kate (part) vi mode :sort function uses only kate \
selection, not vi visual selection" fixed
Problem: Some Kate commands (like :sort) use selection for range but Vi Mode \
clears selection after exiting Visual Mode.
Solution:
1. Keeping selection turned on after entering Command line mode.
2. Clearing selection after exiting Command line mode. (Only for Vi \
Mode)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290064">https://bugs.kde.org/show_bug.cgi?id=290064</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/view/kateviewhelpers.cpp <span style="color: grey">(f71f934)</span></li>
<li>part/vimode/kateviinputmodemanager.h <span style="color: \
grey">(f02a709)</span></li>
<li>part/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(4776380)</span></li>
<li>part/vimode/katevinormalmode.h <span style="color: grey">(6d2a7c8)</span></li>
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(5a59cc2)</span></li>
<li>part/vimode/katevivisualmode.h <span style="color: grey">(e7b417a)</span></li>
<li>part/vimode/katevivisualmode.cpp <span style="color: grey">(67ef9c6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104644/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic