[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kate] part/tests: ensure lines are highlighted
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2011-12-04 20:47:13
Message-ID: 201112042147.13602.dhdev () gmx ! de
[Download RAW message or body]

On Tuesday, 22. November 2011, Milian Wolff wrote:
> On Tuesday 22 November 2011 22:07:59 Dominik Haumann wrote:
> > On Monday, 21. November 2011, Milian Wolff wrote:
> > > Git commit 04f306cef18965749997fecb69f272693f953df5 by Milian Wolff.
> > > Committed on 21/11/2011 at 21:12.
> > > Pushed by mwolff into branch 'master'.
> > > 
> > > ensure lines are highlighted
> > > 
> > > fixes autoCenter folding tests
> > 
> > Now is that a workaround to hide a bug?
> > Or was there never a bug?
> > 
> > There were discussions about this on this list already before...
> 
> True, I was remembering something like that but wasn't sure - thanks for
> bringing it up again.
> 
> Personally I found the following:
> 
> KateView::updateConfig
> -> m_viewInternal->dynWrapChanged();
> 
> this will eventually trigger the call to ensureHighlighted implicitly by
> calling doc->kateTextLine().
> 
> Now I'm not sure whether this is a bug, I never saw any visual bug, only
> this unit test was affected. Maybe also because it never actually shows
> the widget?

Sounds good, then the unit test probably was simply wrong.

Greetings,
Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]