From kwrite-devel  Sun Dec 04 20:47:13 2011
From: Dominik Haumann <dhdev () gmx ! de>
Date: Sun, 04 Dec 2011 20:47:13 +0000
To: kwrite-devel
Subject: Re: [kate] part/tests: ensure lines are highlighted
Message-Id: <201112042147.13602.dhdev () gmx ! de>
X-MARC-Message: https://marc.info/?l=kwrite-devel&m=132303174315701

On Tuesday, 22. November 2011, Milian Wolff wrote:
> On Tuesday 22 November 2011 22:07:59 Dominik Haumann wrote:
> > On Monday, 21. November 2011, Milian Wolff wrote:
> > > Git commit 04f306cef18965749997fecb69f272693f953df5 by Milian Wolff.
> > > Committed on 21/11/2011 at 21:12.
> > > Pushed by mwolff into branch 'master'.
> > > 
> > > ensure lines are highlighted
> > > 
> > > fixes autoCenter folding tests
> > 
> > Now is that a workaround to hide a bug?
> > Or was there never a bug?
> > 
> > There were discussions about this on this list already before...
> 
> True, I was remembering something like that but wasn't sure - thanks for
> bringing it up again.
> 
> Personally I found the following:
> 
> KateView::updateConfig
> -> m_viewInternal->dynWrapChanged();
> 
> this will eventually trigger the call to ensureHighlighted implicitly by
> calling doc->kateTextLine().
> 
> Now I'm not sure whether this is a bug, I never saw any visual bug, only
> this unit test was affected. Maybe also because it never actually shows
> the widget?

Sounds good, then the unit test probably was simply wrong.

Greetings,
Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel