'Review Request: (bug 239077) delay trailing-space-removal until'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request: (bug 239077) delay trailing-space-removal until
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2010-06-24 20:45:31
Message-ID: 20100624204531.13720.33056 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4456/
-----------------------------------------------------------

Review request for Kate.

Summary
-------

Move removal of trailing spaces from KateTextBuffer::load to KateDocument::openFile, \
after config and variable parsing (which might tell us not to remove trailing space!) \
has been performed. Note that the removal also now goes into the undo stack; a \
document that has had removal performed has an undo that can undo the removal and is \
considered modified. (IMHO this is a good thing, but I wouldn't object to a \
modification to suppress undo for the on-load removal. I didn't investigate how to do \
that, however.)

This addresses bug 239077.
    https://bugs.kde.org/show_bug.cgi?id=239077

Diffs
-----

  /trunk/KDE/kdelibs/kate/buffer/katetextbuffer.cpp 1142300 
  /trunk/KDE/kdelibs/kate/document/katebuffer.cpp 1142300 
  /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1142300 

Diff: http://reviewboard.kde.org/r/4456/diff

Testing
-------

Linux, using kwrite and a .kateconfig with 'remove-trailing-space off' (with global \
config remove-trailing-space on)

Thanks,

Matthew

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4456/">http://reviewboard.kde.org/r/4456/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Matthew Woehlke.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Move removal of trailing spaces from \
KateTextBuffer::load to KateDocument::openFile, after config and variable parsing \
(which might tell us not to remove trailing space!) has been performed. Note that the \
removal also now goes into the undo stack; a document that has had removal performed \
has an undo that can undo the removal and is considered modified. (IMHO this is a \
good thing, but I wouldn&#39;t object to a modification to suppress undo for the \
on-load removal. I didn&#39;t investigate how to do that, however.)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Linux, using kwrite and a .kateconfig with \
&#39;remove-trailing-space off&#39; (with global config remove-trailing-space \
on)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=239077">239077</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/kate/buffer/katetextbuffer.cpp <span style="color: \
grey">(1142300)</span></li>

 <li>/trunk/KDE/kdelibs/kate/document/katebuffer.cpp <span style="color: \
grey">(1142300)</span></li>

 <li>/trunk/KDE/kdelibs/kate/document/katedocument.cpp <span style="color: \
grey">(1142300)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4456/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 