--===============0011174413== Content-Type: multipart/alternative; boundary="===============1875955830653135947==" --===============1875955830653135947== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4456/ ----------------------------------------------------------- Review request for Kate. Summary ------- Move removal of trailing spaces from KateTextBuffer::load to KateDocument::= openFile, after config and variable parsing (which might tell us not to rem= ove trailing space!) has been performed. Note that the removal also now goe= s into the undo stack; a document that has had removal performed has an und= o that can undo the removal and is considered modified. (IMHO this is a goo= d thing, but I wouldn't object to a modification to suppress undo for the o= n-load removal. I didn't investigate how to do that, however.) This addresses bug 239077. https://bugs.kde.org/show_bug.cgi?id=3D239077 Diffs ----- /trunk/KDE/kdelibs/kate/buffer/katetextbuffer.cpp 1142300 = /trunk/KDE/kdelibs/kate/document/katebuffer.cpp 1142300 = /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1142300 = Diff: http://reviewboard.kde.org/r/4456/diff Testing ------- Linux, using kwrite and a .kateconfig with 'remove-trailing-space off' (wit= h global config remove-trailing-space on) Thanks, Matthew --===============1875955830653135947== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4456/

Review request for Kate.

By Matthew Woehlke.

Descripti= on

Move removal of trailing spaces fr=
om KateTextBuffer::load to KateDocument::openFile, after config and variabl=
e parsing (which might tell us not to remove trailing space!) has been perf=
ormed. Note that the removal also now goes into the undo stack; a document =
that has had removal performed has an undo that can undo the removal and is=
 considered modified. (IMHO this is a good thing, but I wouldn't object=
 to a modification to suppress undo for the on-load removal. I didn't i=
nvestigate how to do that, however.)

Testing <= /h1>

Linux, using kwrite and a .katecon=
fig with 'remove-trailing-space off' (with global config remove-tra=
iling-space on)

Bugs: 239077

Diffs=

/trunk/KDE/kdelibs/kate/buffer/katetextbuffer.cpp (1142300)
/trunk/KDE/kdelibs/kate/document/katebuffer.cpp (1142300)
/trunk/KDE/kdelibs/kate/document/katedocument.cpp (1142300)

--===============1875955830653135947==-- --===============0011174413== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0011174413==--