[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: current state of kate highlighting/rendering (i.e. the Big Nasty
From:       Mirko Stocker <me () misto ! ch>
Date:       2007-07-19 18:04:46
Message-ID: 200707192004.52035.me () misto ! ch
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Wednesday 18 July 2007 23:35:05 Matthew Woehlke wrote:
> One would think, but I want to say when I tested it it didn't. I haven't
> had time to look at it in a while though.

I just checked out a fresh copy of kate, applied the attached patch and the 
normal text was working correctly (text color, background color and selected 
text color). Tested with no highlighting and with a ruby script.

What I noticed during all the tests, the 'Background Selected' doesn't work, 
but not even on kate 2.5.7...

And by the way, I still can't see the static word wrap marker... :-/ does 
someone else have this problem too?

Thanks

Mirko

["dsnormal.patch" (text/x-diff)]

Index: kate/syntax/katehighlight.cpp
===================================================================
--- kate/syntax/katehighlight.cpp	(revision 689956)
+++ kate/syntax/katehighlight.cpp	(working copy)
@@ -252,8 +252,10 @@
   textLine->clearAttributes ();
 
   // no hl set, nothing to do more than the above cleaning ;)
-  if (noHl)
+  if (noHl) {
+    textLine->addAttribute (0, textLine->length(), KateExtendedAttribute::dsNormal);
     return;
+  }
 
   // duplicate the ctx stack, only once !
   QVector<short> ctx (prevLine->ctxArray());
@@ -485,6 +487,11 @@
     }
     textLine->setNoIndentBasedFolding(noindent);
   }
+
+  //set the dsNormal attribute if we haven't found anything else
+  if(textLine->attributesList().empty()) {
+    textLine->addAttribute (0, textLine->length(), KateExtendedAttribute::dsNormal);
+  }
 }
 
 void KateHighlighting::getKateExtendedAttributeList (const QString &schema, \
QList<KateExtendedAttribute::Ptr> &list)


["signature.asc" (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]