[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: branches/KDE/3.5/kdelibs/kate/part
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2007-04-24 18:46:52
Message-ID: f0ljas$s0m$1 () sea ! gmane ! org
[Download RAW message or body]

Leo Savernik wrote:
> Am Montag, 23. April 2007 schrieb Matthew Woehlke:
>> SVN commit 657332 by mwoehlke:
>>
>> Fix KATE shift+DC selection, finally! This brings selection (in
>> branches/3.5) very close to being 100% right at long last (and adds a FIXME
>> to the only bug I know of still remaining), the final patch should be
>> Coming Real Soon Now. :-) todo: port all of this in one big check-in.

JFTR, I /did/ start a 'please review selection' thread. :-)

> I'm eagerly awaiting that final patch :-)

It's been posted for review already (but I immediately found a different 
bug :-().

> While you're at it, here are some glitches I noticed with current katepart 
> 3.5:

Thanks for the continuing testing!

> 1. DC and move the mouse upwards over the top of the editor canvas. The text 
> should start scrolling, but it doesn't scroll at all.
> 
> 2. DC and move the mouse downwoards over the bottom of the editor canvas. The 
> text starts scrolling but only as long as you wiggle around with the mouse. 
> Note that a SC+move works as expected.

D'oh! Once I pay close enough attention, the problem is obvious. 
Scrolling is done by m_scrollTimer, which is correctly set on mouseClick 
and cleared on mouseRelease. Guess what happens when you double-click:

mousePressEvent -> starts timer
mouseReleaseEvent -> kills timer
mouseDoubleClickEvent -> . . . . . oops!

In fact it seems so obvious in retrospect that I went ahead and 
committed the fix.

> 3. DC some word. Shift+DC some word *above* that word. Move the mouse just 
> right to the *last* character of the initially selected word. The selection 
> vanishes. Now move the mouse downwards. The selection starts flickering like 
> crazy over the whole canvas.

Eew, nuts, shift+DC breaks in this corner case. Thanks for catching this.

> That should keep you busy until the deadline ;-)

...which, fortunately, looks like it is going to be bumped back two 
weeks. :-)

-- 
Matthew
PIE INCOMING!!!

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]