[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: patch to fix indent settings matching the indentation
From:       Anders Lund <anders () alweb ! dk>
Date:       2005-01-31 20:39:27
Message-ID: 200501312139.29203.anders () alweb ! dk
[Download RAW message or body]

On Monday 31 January 2005 21:08, Matt Rogers wrote:
> On Monday 31 January 2005 02:03 pm, Anders Lund wrote:
> > On Monday 31 January 2005 20:20, Matt Rogers wrote:
> > > Hi,
> > >
> > > The following patch reverts a commit from Nov. 02, 2004 that attempts
> > > to allow mixed indenting (i.e. Qt style indentation). Reverting this
> > > patch makes the settings kate actually uses match those displayed in
> > > the default config when those default config settings are not
> > > overridden by a .kateconfig file or a per file mode line. Please review
> > > and approve.
> > >
> > > Thanks,
> > > Matt
> >
> > What is the problem you want address?
>
> Default indentation is 2 spaces now instead of one tab, even though the
> config dialog says _not_ to indent with spaces. We could fix the default
> config, but this still means that their settings are still busted, unless
> people erase the config files for all their apps that use katepart.
>
> > The support for mixed indentation was about a demand. The commit left a
> > problem with the indenting settings, but shouldn't we rather fix that?
>
> I think the way mixed indentation is implemented needs to be rethought and
> possible given it's own modeline parameter since it's not indenting with
> just spaces and its not indenting with just tabs either. just my humble
> opinion since i know nothing about the indenting code.

I agree that the settings we have might not fully cover the combinations 
needed. I'd rather add an option now than disabling the code.

I am going to look at it (indenting configuration) tomorrow or wednessday 
anyway, because of the problems.

-anders
-- 
www: http://alweb.dk
jabber: anderslund@jabber.dk
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]